-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
profiling.ui: make reseting symbols asynchronous #70
base: master
Are you sure you want to change the base?
profiling.ui: make reseting symbols asynchronous #70
Conversation
Remove a slower bit of code from the UI thread. Change-Id: I7278b1466989f2ece24bb844621979641ef647c7 Signed-off-by: Matthew Khouzam <[email protected]>
Found issue when testing exec compare |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This patch should be replicated for the other Flamegraph view as this one will be deprecated in the near future.
new Job("Reseting Symbols") { //$NON-NLS-1$ | ||
@Override | ||
protected IStatus run(@Nullable IProgressMonitor monitor) { | ||
try (FlowScopeLog fsl2 = new FlowScopeLogBuilder(LOGGER, Level.FINE, "Reseting Symbols - inner").setParentScope(fsl).build()) { //$NON-NLS-1$ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, this part should be refactored into a separate function as we have 7 indentation levels.
new Job("Reseting Symbols") { //$NON-NLS-1$ | ||
@Override | ||
protected IStatus run(@Nullable IProgressMonitor monitor) { | ||
try (FlowScopeLog fsl2 = new FlowScopeLogBuilder(LOGGER, Level.FINE, "Reseting Symbols - inner").setParentScope(fsl).build()) { //$NON-NLS-1$ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reseting -> Resetting
Remove a slower bit of code from the UI thread.