tmf.ui: instrument histogram #181
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhufmann
requested changes
Nov 19, 2024
Add two flow scope logs and one scope log. Change-Id: I1b59629da5f7f417880d8f35694fb296eaaddc62 Signed-off-by: Matthew Khouzam <[email protected]>
Speed up histogram by not redrawing when the data is unchanged. Change-Id: Iea05f628da6e1baea4fd0be3b6071f363099c9bb Signed-off-by: Matthew Khouzam <[email protected]>
MatthewKhouzam
force-pushed
the
histogram-tracing
branch
2 times, most recently
from
e247bb1 to
1f99bb8
Compare
|
Updated into two patches. |
bhufmann
reviewed
Nov 20, 2024
| return; | ||
| } | ||
| fDataModel.setSelection(fSelectionBegin, fSelectionEnd); | ||
| HistogramScaledData scaledData = fDataModel.scaleTo(canvasWidth, canvasHeight, 1); |
There was a problem hiding this comment.
shouldn't this be traced as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add early exit when the model is unchanged