Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ExplorerDropTreeItemHandler work only for the default explorer #4286

Open
1 task done
gdaniel opened this issue Dec 11, 2024 · 0 comments · May be fixed by #4288
Open
1 task done

Make ExplorerDropTreeItemHandler work only for the default explorer #4286

gdaniel opened this issue Dec 11, 2024 · 0 comments · May be fixed by #4288
Assignees
@gdaniel
Labels
package: sirius web type: enhancement

Comments

@gdaniel
Copy link
Contributor

gdaniel commented Dec 11, 2024

  • I have checked that this feature has not yet been suggested by someone else.

Expected behavior

The ExplorerDropTreeItemHandler should only work on the default explorer provided by Sirius Web, but it is triggered on any custom explorer implementation.
This prevents downstream applications with a custom explorer from providing a custom IDropTreeItemHandler tailored to their domain.

Cuttings backs

Potential side effects

Implementing this will de-activate the default DnD implementation on custom explorers.
Downstream applications will need to provide their own implementation of IDropTreeItemHandler, potentially by subclassing ExplorerDropTreeItemHandler and changing the canHandle method.
The changelog should reflect this new behavior.

Describe alternatives you've considered
gdaniel added a commit to gdaniel/sirius-web that referenced this issue Dec 11, 2024
@gdaniel
[4286] Make default explorer DnD work only for the default explorer
2aab1f7 
Bug: eclipse-sirius#4286
Signed-off-by: Gwendal Daniel <[email protected]>
@gdaniel gdaniel linked a pull request Dec 11, 2024 that will close this issue
Open
39 tasks
@AxelRICHARD AxelRICHARD linked a pull request Dec 12, 2024 that will close this issue
[4286] Make default explorer DnD work only for the default explorer #4288
Open
39 tasks
@AxelRICHARD AxelRICHARD added this to the 2025.1.0 milestone Dec 12, 2024
gdaniel added a commit to gdaniel/sirius-web that referenced this issue Dec 13, 2024
@gdaniel
[4286] Make default explorer DnD work only for the default explorer
578bb28 
Bug: eclipse-sirius#4286
Signed-off-by: Gwendal Daniel <[email protected]>
gdaniel added a commit to gdaniel/sirius-web that referenced this issue Dec 18, 2024
@gdaniel
[4286] Make default explorer DnD work only for the default explorer
2056b01 
Bug: eclipse-sirius#4286
Signed-off-by: Gwendal Daniel <[email protected]>
@sbegaudeau sbegaudeau removed this from the 2025.1.0 milestone Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gdaniel gdaniel

Labels
package: sirius web type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[4286] Make default explorer DnD work only for the default explorer gdaniel/sirius-web
3 participants
@sbegaudeau @AxelRICHARD @gdaniel