Migrate Ant UI tests to JUnit 4 #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeikoKlare
force-pushed
the
ant-ui-tests-junit4
branch
from
ec4a188
to
845c630
Compare
Test Results 591 files +57 591 suites +57 1h 4m 20s ⏱️ + 5m 24s Results for commit 8d389ac. ± Comparison against base commit 9802acd. This pull request removes 209 and adds 214 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
HeikoKlare
force-pushed
the
ant-ui-tests-junit4
branch
from
845c630
to
1d3a496
Compare
akurtakov
requested changes
Oct 27, 2023
ant/org.eclipse.ant.tests.ui/Ant Tests/org/eclipse/ant/tests/ui/RunInSeparateThreadRule.java
Show resolved
Hide resolved
...pse.ant.tests.ui/test plugin/org/eclipse/ant/tests/ui/testplugin/TestAgainExceptionRule.java
Show resolved
Hide resolved
HeikoKlare
force-pushed
the
ant-ui-tests-junit4
branch
from
1d3a496
to
6ed46f8
Compare
HeikoKlare
force-pushed
the
ant-ui-tests-junit4
branch
4 times, most recently
from
063e5ce
to
fed63fe
Compare
Most tests in org.eclipse.ant.tests.ui are subclasses of AbstractAntUITest, which is still based on JUnit 3 by implementing the TestCase class. This change does the following: * Migrates AbstractAntUITest and subclasses to JUnit 4 * Introduces TestName rules where necessary * Adds the TestAgainExceptionRule, which handles TestAgainExceptions indicating the necessity of test retries * Adds the RunInSeparateThreadRule, which runs the actual test code in a non-UI thread The newly introduced rules replace the overwritten runBare() method of the JUnit 3 tests in a reusable way.
HeikoKlare
force-pushed
the
ant-ui-tests-junit4
branch
from
fed63fe
to
8d389ac
Compare
|
@akurtakov I have added the missing license headers. Can this one be merged? |
akurtakov
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most tests in
org.eclipse.ant.tests.uiare subclasses ofAbstractAntUITest, which is still based on JUnit 3 by implementing theTestCaseclass.This change does the following:
AbstractAntUITestand subclasses to JUnit 4TestNamerules where necessaryTestAgainExceptionRule, which handlesTestAgainExceptionsindicating the necessity of test retriesRunInSeparateThreadRule, which runs the actual test code in a non-UI threadThe newly introduced rules replace the overwritten
runBare()method of the JUnit 3 tests in a reusable way.