Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eclipse 4.30 Prerequisites: ECF #1390

Closed
MohananRahul opened this issue Sep 23, 2023 · 8 comments
Closed

Eclipse 4.30 Prerequisites: ECF #1390

MohananRahul opened this issue Sep 23, 2023 · 8 comments

Comments

@MohananRahul
Copy link
Contributor

MohananRahul commented Sep 23, 2023

Tracking issue for ECF. M1 is scheduled for Sep 29th

@merks
Copy link
Contributor

merks commented Sep 23, 2023

Currently a snapshot version is being used:

<!-- ⚠️ TODO Use a release repo for 3.14.40 before releaseing Platform ⚠️ -->
<repository location="https://download.eclipse.org/rt/ecf/snapshot/site.p2/3.14.40.v20230905-1933/"/>

There appears to be a problem in that version that will likely need another snaphot build to fix it as noted here:

eclipse-equinox/p2#330 (comment)

/cc @scottslewis

@merks
Copy link
Contributor

merks commented Nov 14, 2023

I'm concerned that ECF is current dragging in quite old dependencies via the httpclient feature:

image

I will try to help @scottslewis get this updated; we need a final release build by next Tuesday and ideally would already have a new build today, latest tomorrow I think.

@merks
Copy link
Contributor

merks commented Nov 14, 2023

FYI, these changes from this PR update the above dependencies to the latest:

eclipse/ecf#78 (comment)

@merks
Copy link
Contributor

merks commented Nov 14, 2023

@MohananRahul

What's the latest possible time to update the ECF contribution? I ask because @scottslewis is on the US west coast so could maybe have another snapshot build ready tomorrow morning...

@scottslewis
Copy link

Hi @merks . I'm probably able to do a snapshot build today 11/14/2023 in the afternoon/evening pacific time, but I'm unclear about

a) What (if any) ECF code/build data need to be changed? (I haven't been able to keep up on all the issue notifications over past 24 hours as have real work)
b) Has anyone done any checking/testing of the new httpclient5 versions that you upgraded too? I usually do so by running the ECF filetransfer test suite locally (at least), but I wouldn't want this to go right into Eclipse without some sort of smoke testing of the new/updated versions of httpclient5

I'll try to divine the current state of everything wrt ECF filetransfer by looking at the notifications.

@merks
Copy link
Contributor

merks commented Nov 14, 2023

@scottslewis

a) The PR verification build ran fine so I don't think you need to change anything in your build other than what's in the commit itself.
b) I tested the installer built with the test repository with these versions installed in the installer:

image

That was able to produce an installation without a glitch that way.

So I think we are in good shape from that point of view...

Thanks for your responsiveness!!

@MohananRahul
Copy link
Contributor Author

@MohananRahul

What's the latest possible time to update the ECF contribution? I ask because @scottslewis is on the US west coast so could maybe have another snapshot build ready tomorrow morning...

@merks Usually for Milestone, we take wed 1800 EST build for promotion. please review above pr.

@merks
Copy link
Contributor

merks commented Nov 15, 2023

@scottslewis Thanks for the build.
@MohananRahul Thanks for the PR to incorporate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants