Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean Up VM Accesses in Vector Expansion API for the JITServer #20807

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Clean Up VM Accesses in Vector Expansion API for the JITServer #20807

merged 1 commit into from
Dec 12, 2024
+108 −64

Conversation

luke-li-2003
Copy link
Contributor

Move the relevant VM Accesses in the Vector API to the frontend and remove unnecessary ones to ensure compatability with the JITServer.

Addresses #20798

@luke-li-2003
Copy link
Contributor Author

@mpirvu as per our discussion

@mpirvu mpirvu self-assigned this Dec 10, 2024
@mpirvu mpirvu added the comp:jitserver Artifacts related to JIT-as-a-Service project label Dec 10, 2024
mpirvu
mpirvu reviewed Dec 10, 2024
View reviewed changes
runtime/compiler/env/VMJ9.cpp Show resolved Hide resolved
runtime/compiler/env/VMJ9Server.cpp Outdated Show resolved Hide resolved
runtime/compiler/control/JITClientCompilationThread.cpp Outdated Show resolved Hide resolved
runtime/compiler/optimizer/VectorAPIExpansion.cpp Outdated Show resolved Hide resolved
@knn-k
Copy link
Contributor

knn-k commented Dec 11, 2024

@gita-omr FYI.

@luke-li-2003 luke-li-2003 force-pushed the VectorExpansionVMAccess branch from a3e2265 to a9b18e4 Compare December 11, 2024 17:48
@luke-li-2003
Clean Up VM Accesses in Vector Expansion API for the JITServer
c344c10 
Move the relevant VM Accesses in the Vector API to the frontend
and remove unnecessary ones to ensure compatability with the JITServer.

Signed-off-by: Luke Li <[email protected]>
@luke-li-2003 luke-li-2003 force-pushed the VectorExpansionVMAccess branch from a9b18e4 to c344c10 Compare December 11, 2024 18:02
@mpirvu
Copy link
Contributor

mpirvu commented Dec 11, 2024

jenkins compile all jdk21

@mpirvu
Copy link
Contributor

mpirvu commented Dec 11, 2024

jenkins test sanity zlinuxjit jdk21

@mpirvu
Copy link
Contributor

mpirvu commented Dec 12, 2024

One test failing on zLinux:

14:23:04  Running test jdk_lang_1 ...
14:23:04  ===============================================
14:23:04  jdk_lang_1 Start Time: Wed Dec 11 19:23:04 2024 Epoch Time (ms): 1733944984479
variation: -Xdump:system:none -Xdump:heap:none -Xdump:system:events=gpf+abort+traceassert+corruptcache -XX:-JITServerTechPreviewMessage Mode650
14:23:04  JVM_OPTIONS: -XX:+UseJITServer -Xdump:system:none -Xdump:heap:none -Xdump:system:events=gpf+abort+traceassert+corruptcache -XX:-JITServerTechPreviewMessage -XX:-UseCompressedOops -Xverbosegclog 
...
5:02:22  ACTION: junit -- Error. Program `/home/jenkins/workspace/Test_openjdk21_j9_sanity.openjdk_s390x_linux_jit_Personal_testList_1/jdkbinary/j2sdk-image/bin/java' timed out (timeout set to 960000ms, elapsed time including timeout handling was 992773ms).

I remember seeing this failure before, hence merging.

@mpirvu mpirvu merged commit c6d3e93 into eclipse-openj9:master Dec 12, 2024
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpirvu mpirvu mpirvu approved these changes

@dsouzai dsouzai Awaiting requested review from dsouzai dsouzai is a code owner

Assignees

@mpirvu mpirvu

Labels
comp:jitserver Artifacts related to JIT-as-a-Service project
Projects
JIT as a Service
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luke-li-2003 @knn-k @mpirvu