Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bypass Code Requiring VM Read at JITServer #20757

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

luke-li-2003
Copy link
Contributor

Bypass the code that requires a VM read in constraintRecognizedMethod under JITServer mode, to prevent an invalid class pointer being sent to the client and crashing the client.

This block of code should only be reached in jdk11, fixing a crash caused by eclipse-omr/omr#7565.

@luke-li-2003
Copy link
Contributor Author

@mpirvu

@mpirvu mpirvu self-assigned this Dec 4, 2024
@mpirvu mpirvu added comp:jit comp:jitserver Artifacts related to JIT-as-a-Service project labels Dec 4, 2024
Bypass the code that requires a VM read in constraintRecognizedMethod
under JITServer mode, to prevent an invalid class pointer being sent
to the client and crashing the client.

This block of code should only be reached in jdk11.

Signed-off-by: Luke Li <[email protected]>
Copy link
Contributor

@mpirvu mpirvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpirvu
Copy link
Contributor

mpirvu commented Dec 4, 2024

jenkins test sanity zlinuxjit jdk11

@mpirvu
Copy link
Contributor

mpirvu commented Dec 4, 2024

jenkins test sanity xlinuxjit jdk11 depends eclipse/omr#master

@mpirvu mpirvu merged commit 70dd02e into eclipse-openj9:master Dec 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:jit comp:jitserver Artifacts related to JIT-as-a-Service project
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants