-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add java.lang.Access.allowSecurityManager to jdk21 #20749
Conversation
Set as draft as it needs to be merged concurrently with jdk21 openj9-staging promotion. |
Once we get a review approval on this, we can run the equivalent of the acceptance build. |
/*[IF (JAVA_SPEC_VERSION >= 21) & (JAVA_SPEC_VERSION < 24)]*/ | ||
@Override | ||
public boolean allowSecurityManager() { | ||
return System.allowSecurityManager(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
openj9/jcl/src/java.base/share/classes/java/lang/System.java
Lines 1304 to 1308 in f8939d1
/*[IF JAVA_SPEC_VERSION == 23]*/ | |
static boolean allowSecurityManager() { | |
return !throwUOEFromSetSM; | |
} | |
/*[ENDIF] JAVA_SPEC_VERSION == 23 */ |
System.allowSecurityManager()
is needed for JDK21.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right... updated.
Issue eclipse-openj9#20748 Signed-off-by: Peter Shipton <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jenkins test sanity all jdk21 depends ibmruntime/openj9-openjdk-jdk21#openj9-staging |
The aarch64_linux build encountered what looked like an infrastructure problem: I restarted it. |
Closes #20748