Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add java.lang.Access.allowSecurityManager to jdk21 #20749

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

pshipton
Copy link
Member

@pshipton pshipton commented Dec 4, 2024

Closes #20748

@pshipton
Copy link
Member Author

pshipton commented Dec 4, 2024

Set as draft as it needs to be merged concurrently with jdk21 openj9-staging promotion.

@pshipton
Copy link
Member Author

pshipton commented Dec 4, 2024

Once we get a review approval on this, we can run the equivalent of the acceptance build.

/*[IF (JAVA_SPEC_VERSION >= 21) & (JAVA_SPEC_VERSION < 24)]*/
@Override
public boolean allowSecurityManager() {
return System.allowSecurityManager();
Copy link
Member

@JasonFengJ9 JasonFengJ9 Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/*[IF JAVA_SPEC_VERSION == 23]*/
static boolean allowSecurityManager() {
return !throwUOEFromSetSM;
}
/*[ENDIF] JAVA_SPEC_VERSION == 23 */

System.allowSecurityManager() is needed for JDK21.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right... updated.

Copy link
Member

@JasonFengJ9 JasonFengJ9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pshipton
Copy link
Member Author

pshipton commented Dec 4, 2024

jenkins test sanity all jdk21 depends ibmruntime/openj9-openjdk-jdk21#openj9-staging

@keithc-ca
Copy link
Contributor

The aarch64_linux build encountered what looked like an infrastructure problem: I restarted it.

@pshipton pshipton marked this pull request as ready for review December 4, 2024 21:00
@pshipton pshipton merged commit a0c3031 into eclipse-openj9:master Dec 4, 2024
17 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jdk21 acceptance fails to compile
3 participants