-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accelerate StringCoding.countPositives on Z #20736
base: master
Are you sure you want to change the base?
Accelerate StringCoding.countPositives on Z #20736
Conversation
Signed-off-by: Dhruv Chopra <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks ok to me (Structure wise). Please add short description to commit.
I will give detail review once you confirm passing of functional tests. Also Can I request you to share the instruction selection snippet ?
Signed-off-by: Dhruv Chopra <[email protected]>
Instruction Log:
|
@r30shah Sanity build is clean now so this is ready for detailed review. The instruction log I posted earlier is consistent with the latest changes. |
This PR accelerates the
StringCoding.countPositives
API on z/codegen for JDK21+. This API is similar in implementation to the recently acceleratedStringCoding.hasNegatives
API so we leverage the existing implementation to add acceleration forStringCoding.countPositives
as well.