Add JFR ClassLoadingStatistics support #20679
Merged
+141
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tajila FYI |
tajila
reviewed
Nov 29, 2024
runtime/vm/jfr.cpp
Outdated
| vm->memoryManagerFunctions->j9gc_get_cumulative_class_unloading_stats(currentThread, NULL, &unloadedClassCount, NULL); | ||
| jfrEvent->unloadedClassCount = (I_64)unloadedClassCount; | ||
|
|
||
| pool_state clState = {0}; |
There was a problem hiding this comment.
you should use the allClassLoadersStartDo API instead which acquires the correct class mutex
There was a problem hiding this comment.
allClassLoadersNextDo and allClassLoadersEndDo
There was a problem hiding this comment.
also, you need to release VM access before starting the classloading walk so you are not holding on to VM access while waiting for a lock
thallium
force-pushed
the
jfr-class-loading-stats
branch
from
cf626d7
to
5db0741
Compare
tajila
reviewed
Dec 4, 2024
tajila
reviewed
Dec 4, 2024
Signed-off-by: Gengchen Tuo <[email protected]>
thallium
force-pushed
the
jfr-class-loading-stats
branch
from
5db0741
to
b261309
Compare
|
jenkins test sanity xlinux jdk17 |
tajila
approved these changes
Dec 5, 2024
|
@thallium Please create a PR for 0.49 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.