-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JFR ClassLoadingStatistics support #20679
Conversation
@tajila FYI |
runtime/vm/jfr.cpp
Outdated
vm->memoryManagerFunctions->j9gc_get_cumulative_class_unloading_stats(currentThread, NULL, &unloadedClassCount, NULL); | ||
jfrEvent->unloadedClassCount = (I_64)unloadedClassCount; | ||
|
||
pool_state clState = {0}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should use the allClassLoadersStartDo
API instead which acquires the correct class mutex
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
allClassLoadersNextDo
and allClassLoadersEndDo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, you need to release VM access before starting the classloading walk so you are not holding on to VM access while waiting for a lock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
cf626d7
to
5db0741
Compare
Signed-off-by: Gengchen Tuo <[email protected]>
5db0741
to
b261309
Compare
jenkins test sanity xlinux jdk17 |
@thallium Please create a PR for 0.49 |
No description provided.