Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JFR ClassLoadingStatistics support #20679

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

thallium
Copy link
Contributor

No description provided.

@thallium
Copy link
Contributor Author

@tajila FYI

vm->memoryManagerFunctions->j9gc_get_cumulative_class_unloading_stats(currentThread, NULL, &unloadedClassCount, NULL);
jfrEvent->unloadedClassCount = (I_64)unloadedClassCount;

pool_state clState = {0};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should use the allClassLoadersStartDo API instead which acquires the correct class mutex

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

allClassLoadersNextDo and allClassLoadersEndDo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, you need to release VM access before starting the classloading walk so you are not holding on to VM access while waiting for a lock

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@tajila
Copy link
Contributor

tajila commented Dec 4, 2024

jenkins test sanity xlinux jdk17

@tajila tajila merged commit f6d6d01 into eclipse-openj9:master Dec 5, 2024
6 checks passed
@tajila
Copy link
Contributor

tajila commented Dec 5, 2024

@thallium Please create a PR for 0.49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants