Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a setting file to control options used in Java16andUp tests #20647

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Add a setting file to control options used in Java16andUp tests #20647

merged 1 commit into from
Nov 21, 2024

Conversation

hangshao0
Copy link
Contributor

@hangshao0 hangshao0 commented Nov 20, 2024 •
edited
Loading

Add variable ENABLE_PREVIEW to enable option --enable-preview in
Jep397Tests in Valhalla standard build

Fixes #20575

@hangshao0
Copy link
Contributor Author

Jenkins test sanity.functional alinuxvalst jdknext

@hangshao0
Copy link
Contributor Author

Jenkins test sanity.functional amac jdk21

@hangshao0
Copy link
Contributor Author

Jenkins test sanity.functional alinuxvalst jdknext

@pshipton
Copy link
Member

"Add file for new settings" is fairly meaningless, it doesn't tell you much about that is changing. Pls improve it.

@hangshao0
Copy link
Contributor Author

"Add file for new settings" is fairly meaningless, it doesn't tell you much about that is changing. Pls improve it.

I will do that before making this PR ready to review. It is still a draft PR that is subject to change.

@hangshao0
Copy link
Contributor Author

Links to PR builds:

https://openj9-jenkins.osuosl.org/job/Test_openjdk21_j9_sanity.functional_aarch64_mac_Personal/145/ (Passed)
https://openj9-jenkins.osuosl.org/job/Test_openjdknext_j9_sanity.functional_aarch64_linux_vt_standard_Personal/16/ (Failures not related to this change)

@hangshao0 hangshao0 force-pushed the Test branch 2 times, most recently from b530d89 to c617f26 Compare November 21, 2024 20:29
@hangshao0 hangshao0 changed the title Add file for new settings Add a setting file to control options used in Java16andUp tests Nov 21, 2024
@hangshao0 hangshao0 added comp:test project:valhalla Used to track Project Valhalla related work labels Nov 21, 2024
@hangshao0 hangshao0 requested a review from llxia November 21, 2024 20:30
@hangshao0
Add a setting file to control options used in Java16andUp tests
e598afe 
Add variable ENABLE_PREVIEW to enable option --enable-preview in
Jep397Tests in Valhalla standard build

Fixes eclipse-openj9#20575

Signed-off-by: Hang Shao <[email protected]>
@hangshao0 hangshao0 marked this pull request as ready for review November 21, 2024 20:38
llxia
llxia approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia llxia merged commit 27dbff5 into eclipse-openj9:master Nov 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llxia llxia llxia approved these changes

Assignees
No one assigned
Labels
comp:test project:valhalla Used to track Project Valhalla related work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jep397Tests_testSubClassOfSealedSuperFromDifferentPackageInSameUnamedModule_0 failed in VT_standard build
3 participants
@hangshao0 @pshipton @llxia