Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable openjdk test - jdk_jmx #20587

Closed
llxia opened this issue Nov 13, 2024 · 16 comments · Fixed by adoptium/aqa-tests#5786
Closed

Re-enable openjdk test - jdk_jmx #20587

llxia opened this issue Nov 13, 2024 · 16 comments · Fixed by adoptium/aqa-tests#5786
Assignees
@llxia
Labels
comp:test

Comments

@llxia
Copy link
Contributor

llxia commented Nov 13, 2024

jdk_jmx got excluded as part of the general exclude a while back via #10757.

https://github.com/adoptium/aqa-tests/blob/a498becc695f7bdeaa7c4b3752c827e65aa7e123/openjdk/playlist.xml#L1620

My limited testing on JDK11 xlinux passed 244 testes and 4 failed. We should look into re-enabling this test.

# TESTCASES RESULTS SUMMARY: passed: 244; failed: 3; error: 1; skipped: 0 
1..1
not ok 1 - jdk_jmx_0
  ---
    output:
      |
        Failed test cases: 
        TEST: javax/management/MBeanServer/OldMBeanServerTest.java
        TEST: javax/management/mxbean/LeakTest.java
        TEST: javax/management/remote/mandatory/notif/ListenerScaleTest.java
        TEST: javax/management/security/HashedPasswordFileTest.java
        Test results: passed: 244; failed: 3; error: 1
    duration_ms: 368171
  ...
@github-actions GitHub Actions
Copy link

Issue Number: 20587
Status: Open
Recommended Components: comp:test, comp:vm, comp:build
Recommended Assignees: pshipton, jasonfengj9, llxia

@llxia
Copy link
Contributor Author

llxia commented Nov 13, 2024 •
edited
Loading

TEST: javax/management/mxbean/LeakTest.java

For Error evaluating expression: invalid boolean value: 'null' for expression vm.opt.final.ClassUnloading'`, https://github.com/ibmruntimes/openj9-openjdk-jdk11/blob/openj9/closed/test/jtreg-ext/requires/OpenJ9PropsExt.java will be updated. Similar to https://github.com/ibmruntimes/openj9-openjdk-jdk19/blob/openj9/closed/test/jtreg-ext/requires/OpenJ9PropsExt.java#L55C13-L55C61

@llxia
Copy link
Contributor Author

llxia commented Nov 15, 2024 •
edited
Loading

@pshipton, could you look at the other 3 test failures in Grinder? They look like real failures to me.
jdk_jmx passed in hotspot: https://ci.adoptium.net/job/Test_openjdk11_hs_extended.openjdk_x86-64_linux_testList_2/28/testReport/

TEST: javax/management/MBeanServer/OldMBeanServerTest.java

testPlatformMBeanServer: got exception javax.management.AttributeNotFoundException
javax.management.AttributeNotFoundException: Write-only attribute: DumpOptions
	at java.management/com.sun.jmx.mbeanserver.PerInterface.getAttribute(PerInterface.java:81)
	at java.management/com.sun.jmx.mbeanserver.MBeanSupport.getAttribute(MBeanSupport.java:206)
	at java.management/javax.management.StandardMBean.getAttribute(StandardMBean.java:372)
	at OldMBeanServerTest$OldMBeanServer.getAttribute(OldMBeanServerTest.java:610)
	at OldMBeanServerTest.printAttrs(OldMBeanServerTest.java:358)
	at OldMBeanServerTest.testPlatformMBeanServer(OldMBeanServerTest.java:340)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:572)
	at OldMBeanServerTest.runTests(OldMBeanServerTest.java:189)
	at OldMBeanServerTest.main(OldMBeanServerTest.java:134)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:572)
	at com.sun.javatest.regtest.agent.MainWrapper$MainTask.run(MainWrapper.java:138)
	at java.base/java.lang.Thread.run(Thread.java:835)

TEST: javax/management/remote/mandatory/notif/ListenerScaleTest.java

It is fixed. See #20587 (comment)

java.lang.NullPointerException
	at jdk.test.lib.Platform.isDebugBuild(Platform.java:185)
	at ListenerScaleTest.main(ListenerScaleTest.java:135)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:572)
	at com.sun.javatest.regtest.agent.MainWrapper$MainTask.run(MainWrapper.java:138)
	at java.base/java.lang.Thread.run(Thread.java:835)

JavaTest Message: Test threw exception: java.lang.NullPointerException
JavaTest Message: shutting down test

STATUS:Failed.`main' threw exception: java.lang.NullPointerException

TEST: javax/management/security/HashedPasswordFileTest.java

Execution failed: `main' threw exception: java.lang.Exception: failures: 2

@llxia
Copy link
Contributor Author

llxia commented Nov 15, 2024 •
edited
Loading

TEST: javax/management/remote/mandatory/notif/ListenerScaleTest.java

related to #20534.

Since the fix was delivered 3 days ago, rerun with the latest SDK - ListenerScaleTest passed

pshipton added a commit to pshipton/openj9-openjdk-jdk17 that referenced this issue Nov 15, 2024
@pshipton
Set test flag vm.opt.final.ClassUnloading
c5607ff 
Backport ibmruntimes/openj9-openjdk-jdk21#34

Issue eclipse-openj9/openj9#20587

Signed-off-by: Peter Shipton <[email protected]>
@pshipton pshipton mentioned this issue Nov 15, 2024
Merged
pshipton added a commit to pshipton/openj9-openjdk-jdk11 that referenced this issue Nov 15, 2024
@pshipton
Set test flag vm.opt.final.ClassUnloading
5ab34fc 
Backport ibmruntimes/openj9-openjdk-jdk21#34

Issue eclipse-openj9/openj9#20587

Signed-off-by: Peter Shipton <[email protected]>
@pshipton pshipton mentioned this issue Nov 15, 2024
Merged
pshipton added a commit to pshipton/openj9-openjdk-jdk11 that referenced this issue Nov 15, 2024
@pshipton
Set test flag vm.opt.final.ClassUnloading
fa2f478 
Backport ibmruntimes/openj9-openjdk-jdk21#34

Issue eclipse-openj9/openj9#20587

Signed-off-by: Peter Shipton <[email protected]>
@pshipton
Copy link
Member

Re #20587 (comment), added the missing vm.opt.final.ClassUnloading flag for jdk11 & 17.

@pshipton
Copy link
Member

HashedPasswordFileTest.java needs to be excluded for OpenJ9. OpenJ9 doesn't implement Perf.

16:34:26  [TestApp] Exception in thread "main" java.lang.UnsupportedOperationException
16:34:26  [TestApp] 	at java.base/jdk.internal.perf.Perf.attach(Native Method)
16:34:26  [TestApp] 	at java.base/jdk.internal.perf.Perf.attachImpl(Perf.java:272)
16:34:26  [TestApp] 	at java.base/jdk.internal.perf.Perf.attach(Perf.java:202)
16:34:26  [TestApp] 	at jdk.management.agent/jdk.internal.agent.ConnectorAddressLink.importRemoteFrom(ConnectorAddressLink.java:203)
16:34:26  [TestApp] 	at TestApp.main(HashedPasswordFileTest.java:503)

@llxia llxia mentioned this issue Nov 15, 2024
Closed
llxia added a commit to llxia/aqa-tests that referenced this issue Nov 15, 2024
@llxia
Permanent exclude HashedPasswordFileTest
f63c9e7 
related: eclipse-openj9/openj9#20587 (comment)

Signed-off-by: Lan Xia <[email protected]>
@llxia llxia mentioned this issue Nov 15, 2024
Merged
pshipton added a commit to pshipton/openj9 that referenced this issue Nov 15, 2024
@pshipton
Add OpenJ9DiagnosticsMXBean.getDumpOptions
6df43d4 
There should be a getter to match the setter.

Issue eclipse-openj9#20587

Signed-off-by: Peter Shipton <[email protected]>
pshipton added a commit to pshipton/openj9 that referenced this issue Nov 15, 2024
@pshipton
Add OpenJ9DiagnosticsMXBean.getDumpOptions
0cdeeb2 
There should be a getter to match the setter.

Issue eclipse-openj9#20587

Signed-off-by: Peter Shipton <[email protected]>
@pshipton pshipton mentioned this issue Nov 15, 2024
Merged
@pshipton
Copy link
Member

For fixing OldMBeanServerTest.java, the first PR
#20604

JasonFengJ9 pushed a commit to adoptium/aqa-tests that referenced this issue Nov 15, 2024
@llxia
Permanent exclude HashedPasswordFileTest (#5755)
b184eaa 
related: eclipse-openj9/openj9#20587 (comment)

Signed-off-by: Lan Xia <[email protected]>
pshipton added a commit to pshipton/openj9 that referenced this issue Nov 15, 2024
@pshipton
Move CRaCMXBeanImpl and export jdk.crac.management
19d666a 
Issue eclipse-openj9#20587

Signed-off-by: Peter Shipton <[email protected]>
@pshipton pshipton mentioned this issue Nov 15, 2024
Merged
@pshipton
Copy link
Member

The second PR
#20605

@pshipton pshipton mentioned this issue Nov 15, 2024
Open
@pshipton
Copy link
Member

pshipton commented Nov 15, 2024 •
edited
Loading

Opened #20607 for the next failure. If you want to enable jdk_jmx, pls exclude javax/management/MBeanServer/OldMBeanServerTest.java on the jfr platforms (currently alinux, xlinux) until it's fixed. See the next comment.

@llxia llxia mentioned this issue Nov 15, 2024
Open
pshipton added a commit to pshipton/openj9 that referenced this issue Nov 16, 2024
@pshipton
Move CRaCMXBeanImpl and export jdk.crac.management
1af5097 
Issue eclipse-openj9#20587

Signed-off-by: Peter Shipton <[email protected]>
@pshipton
Copy link
Member

We can set -Djfr.unsupported.vm=true to allow the test to pass, rather than excluding it on jfr platforms.

sophia-guo pushed a commit to sophia-guo/openjdk-tests that referenced this issue Nov 18, 2024
@llxia @sophia-guo
Permanent exclude HashedPasswordFileTest (adoptium#5755)
bc22904 
related: eclipse-openj9/openj9#20587 (comment)

Signed-off-by: Lan Xia <[email protected]>
@pshipton
Copy link
Member

Setting jfr.unsupported.vm to true was done via #20631

pshipton added a commit to pshipton/openj9 that referenced this issue Nov 19, 2024
@pshipton
Add OpenJ9DiagnosticsMXBean.getDumpOptions
e9bd592 
There should be a getter to match the setter.

Issue eclipse-openj9#20587

Signed-off-by: Peter Shipton <[email protected]>
pshipton added a commit to pshipton/openj9 that referenced this issue Nov 19, 2024
@pshipton
Add OpenJ9DiagnosticsMXBean.getDumpOptions
5aeec27 
There should be a getter to match the setter.

Issue eclipse-openj9#20587

Signed-off-by: Peter Shipton <[email protected]>
pshipton added a commit to pshipton/openj9 that referenced this issue Nov 19, 2024
@pshipton
Add OpenJ9DiagnosticsMXBean.getDumpOptions
f47afa7 
There should be a getter to match the setter.

Issue eclipse-openj9#20587

Signed-off-by: Peter Shipton <[email protected]>
pshipton added a commit to pshipton/openj9 that referenced this issue Nov 19, 2024
@pshipton
Add OpenJ9DiagnosticsMXBean.getDumpOptions
e85729a 
There should be a getter to match the setter.

Issue eclipse-openj9#20587

Signed-off-by: Peter Shipton <[email protected]>
h3110n3rv3 added a commit to h3110n3rv3/openj9 that referenced this issue Nov 19, 2024
@h3110n3rv3
Squashed commit of the following:
09434fe 
commit 44766de
Merge: 975e741 fe89ec5
Author: Marius Pirvu <[email protected]>
Date:   Tue Nov 19 09:18:48 2024 -0500

    Merge pull request eclipse-openj9#20614 from JamesKingdon/trampolineResetFix

    Reset trampoline pointers to top of space

commit 975e741
Merge: 9618d90 9f566fa
Author: Peter Shipton <[email protected]>
Date:   Tue Nov 19 08:34:48 2024 -0500

    Merge pull request eclipse-openj9#20631 from tajila/jfr3

    Disable JFR JCL APIs

commit 9618d90
Merge: 8f240e6 36dc396
Author: Dmitri Pivkine <[email protected]>
Date:   Mon Nov 18 21:45:37 2024 -0500

    Merge pull request eclipse-openj9#20630 from amicic/VLHGC_barrier_32bit

    Don't use Offheap APIs for 32 bit

commit 9f566fa
Author: tajila <[email protected]>
Date:   Mon Nov 18 20:05:47 2024 -0500

    Disable JFR JCL APIs

    Disable JFR JCL APIs until JFR natives are implemented.

    Related to: eclipse-openj9#20607

    Signed-off-by: tajila <[email protected]>

commit 8f240e6
Merge: 7534b4e 6662a08
Author: Keith W. Campbell <[email protected]>
Date:   Mon Nov 18 20:05:46 2024 -0500

    Merge pull request eclipse-openj9#20621 from tajila/jfr2

    Fix conditon in JFR buffer test

commit 6662a08
Author: tajila <[email protected]>
Date:   Mon Nov 18 15:49:59 2024 -0500

    Fix conditon in JFR buffer test

    Signed-off-by: tajila <[email protected]>

commit 36dc396
Author: Aleksandar Micic <[email protected]>
Date:   Mon Nov 18 19:11:09 2024 -0500

    Don't use Offheap APIs for 32 bit

    A couple of Offheap APIs are guarded with 64 bit compile flag.

    A more accurate fix would be to guard them with Offheap specific build
    flag (and do not compile the whole dir for 32bit), but it would require
    more complex changes.

    Signed-off-by: Aleksandar Micic <[email protected]>

commit 7534b4e
Merge: 3d719d4 276f38f
Author: Graham Chapman <[email protected]>
Date:   Mon Nov 18 18:14:00 2024 -0500

    Merge pull request eclipse-openj9#20620 from tajila/jfr3

    Release jfrSampler lock before acquiring VMaccess

commit 3d719d4
Merge: 247d6ec c0ff1fc
Author: Peter Shipton <[email protected]>
Date:   Mon Nov 18 17:17:42 2024 -0500

    Merge pull request eclipse-openj9#20622 from AdamBrousseau/cuda_docker_non_dockerhub

    Pull cuda image from nvcr

commit 247d6ec
Merge: 068838e fee4aeb
Author: Aleksandar Micic <[email protected]>
Date:   Mon Nov 18 16:55:50 2024 -0500

    Merge pull request eclipse-openj9#20514 from LinHu2016/coding-std-update2

    Clean up MethodTypesIterator class

commit 068838e
Merge: d98d498 3dc8eb4
Author: Aleksandar Micic <[email protected]>
Date:   Mon Nov 18 16:46:15 2024 -0500

    Merge pull request eclipse-openj9#20564 from LinHu2016/off-heap-incremental4

    New vm/gc API j9gc_objaccess_indexableDataDisplacement

commit c0ff1fc
Author: Adam Brousseau <[email protected]>
Date:   Mon Nov 18 16:03:35 2024 -0500

    Pull cuda image from nvcr

    In the event we are rate-limited or restricted from pulling
    from DockerHub, this should work around the problem by pulling
    from Nvidia's site.

    Issue runtimes/automation/122

    Signed-off-by: Adam Brousseau <[email protected]>

commit 3dc8eb4
Author: lhu <[email protected]>
Date:   Fri Nov 8 11:50:32 2024 -0500

    New vm/gc API j9gc_objaccess_indexableDataDisplacement

    new API j9gc_objaccess_indexableDataDisplacement used by the JIT.
    Returns the displacement for the data of moved array object.
    For adjacent Array and 0 size array, displacement = dst - src
    For Off-heap Array, displacement = 0
    should only be called for off-heap eanbled case.

    Signed-off-by: lhu <[email protected]>

commit d98d498
Merge: 77f153d ee35ed5
Author: Graham Chapman <[email protected]>
Date:   Mon Nov 18 14:52:20 2024 -0500

    Merge pull request eclipse-openj9#20611 from tajila/jfr2

    Prevent writes to free'd JFR buffer

commit 77f153d
Merge: 038df36 326a800
Author: Marius Pirvu <[email protected]>
Date:   Mon Nov 18 14:09:15 2024 -0500

    Merge pull request eclipse-openj9#20592 from luke-li-2003/ServerCacheReflectClass

    Cache Client's Reflect Class Pointers at JITServer

commit 276f38f
Author: tajila <[email protected]>
Date:   Mon Nov 18 13:59:52 2024 -0500

    Release jfrSampler lock before acquiring VMaccess

    Signed-off-by: tajila <[email protected]>

commit ee35ed5
Author: tajila <[email protected]>
Date:   Sun Nov 17 16:06:08 2024 -0500

    Prevent writes to free'd JFR buffer

    Also, check that threadObject is not NULL before dereference.

    Signed-off-by: tajila <[email protected]>

commit 038df36
Merge: 224374d 0573107
Author: Aleksandar Micic <[email protected]>
Date:   Mon Nov 18 11:12:43 2024 -0500

    Merge pull request eclipse-openj9#20596 from LinHu2016/off-heap-incremental6

    Update verbose GC for off-heap

commit 224374d
Merge: 6289c28 d56338f
Author: Babneet Singh <[email protected]>
Date:   Mon Nov 18 10:20:28 2024 -0500

    Merge pull request eclipse-openj9#20606 from ThanHenderson/omr-unnamed

    Fix OMR_GLUE unnamed spelling mistake

commit 6289c28
Merge: efaa4f6 1af5097
Author: Tobi <[email protected]>
Date:   Mon Nov 18 09:56:54 2024 -0500

    Merge pull request eclipse-openj9#20605 from pshipton/cracbean

    Move CRaCMXBeanImpl and export jdk.crac.management

commit 1af5097
Author: Peter Shipton <[email protected]>
Date:   Fri Nov 15 14:28:45 2024 -0500

    Move CRaCMXBeanImpl and export jdk.crac.management

    Issue eclipse-openj9#20587

    Signed-off-by: Peter Shipton <[email protected]>

commit 326a800
Author: Luke Li <[email protected]>
Date:   Thu Nov 14 16:13:54 2024 -0500

    Remove J9Class Occurrences in Vector API

    Substitute uses of J9Class in the vector API with TR_OpaqueClassBlock
    with frontend references.

    The Vector API, being a part of the optimizer, should never use the
    inside of a J9Class

    Signed-off-by: Luke Li <[email protected]>

commit a97a4ba
Author: Luke Li <[email protected]>
Date:   Mon Oct 28 09:31:53 2024 -0400

    Remove Server VM Access Request in VectorAPIExpansion.cpp

    The server should make a specific request to the client in
    getJ9ClassFromClassNode() and getVectorSizeFromVectorSpecies(),
    instead of requesting a pointer from the KnownObjectTable as
    that requires VM Access and will cause a fatal assertion fail
    at J9KnownObjectTable.cpp:207.

    Signed-off-by: Luke Li <[email protected]>

commit fe89ec5
Author: James Kingdon <[email protected]>
Date:   Fri Nov 15 15:24:35 2024 -0500

    Reset trampoline pointers to top of space

    After flushing the code cache under FSD there is a call to resetTrampolines.
    The _trampolineAllocationMark and _trampolineReservationMark need to be reset
    to their starting positions but were incorrectly set to the end of the trampoline
    space. As a result all active segments at the time of the cache flush are marked
    as full (assuming a platform that uses trampolines). This can be seen by taking
    a JIT verbose log with option `codecache` which will show

    CODECACHE:  CodeCache 00007E759000C660 marked as full in reserveSpaceForTrampoline

commit d56338f
Author: Nathan Henderson <[email protected]>
Date:   Fri Nov 15 11:32:46 2024 -0800

    Fix OMR_GLUE unnamed spelling mistake

    Signed-off-by: Nathan Henderson <[email protected]>

commit 0573107
Author: lhu <[email protected]>
Date:   Tue Nov 12 12:09:29 2024 -0500

    Update verbose GC for off-heap

     -new outputOffHeapInfo in CopyForward and Mark for balancedGC
      <offheap candidates="xxx" cleared="xxx" />"
     - output offheap-objects in MemoryInfo
      <offheap-objects objects="xxx" bytes="xxx" />

    Signed-off-by: lhu <[email protected]>

commit fee4aeb
Author: lhu <[email protected]>
Date:   Tue Nov 5 10:51:09 2024 -0500

    Clean up MethodTypesIterator class

    Use consistent data types and code formatting

    Signed-off-by: lhu <[email protected]>
pshipton added a commit to pshipton/openj9 that referenced this issue Nov 20, 2024
@pshipton
Add OpenJ9DiagnosticsMXBean.getDumpOptions
73d61a8 
There should be a getter to match the setter.

Issue eclipse-openj9#20587

Signed-off-by: Peter Shipton <[email protected]>
@llxia
Copy link
Contributor Author

llxia commented Dec 3, 2024

I ran the test on all platforms with the latest JDK11. All passed except windows:

00:03:12.576  openjdk version "11.0.25-internal" 2024-10-15
00:03:12.576  OpenJDK Runtime Environment (build 11.0.25-internal+0-adhoc.jenkins.buildjdk11x86-64windowsnightly)
00:03:12.576  Eclipse OpenJ9 VM (build master-2583a83f213, JRE 11 Windows Server 2019 amd64-64-Bit Compressed References 20241113_908 (JIT enabled, AOT enabled)
00:03:12.576  OpenJ9   - 2583a83f213
00:03:12.576  OMR      - 3da49aa3aae
00:03:12.576  JCL      - 3ba776f9840 based on jdk-11.0.25+9)

Parent job
Windows - Noticed javax.management.AttributeNotFoundException: Write-only attribute: DumpOptions error on Windows

@pshipton could you take a look?

@pshipton
Copy link
Member

pshipton commented Dec 3, 2024

I think your Windows build is too old. The fix is merged on the 20th. #20604

@pshipton
Copy link
Member

pshipton commented Dec 3, 2024

If this is an external OpenJ9 build, we lost all the Windows build machines some time ago, there are no recent Windows builds.

@llxia
Copy link
Contributor Author

llxia commented Dec 3, 2024

ah, yes, I used an external OpenJ9 build. Thanks Peter.

llxia added a commit to llxia/aqa-tests that referenced this issue Dec 3, 2024
@llxia
Re-enable jdk_jmx for openj9
4de2ab3 
resolves: eclipse-openj9/openj9#20587

Signed-off-by: Lan Xia <[email protected]>
@llxia llxia mentioned this issue Dec 3, 2024
Merged
@llxia llxia self-assigned this Dec 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024

Issue Number: 20587
Status: Closed
Actual Components: comp:test
Actual Assignees: No one :(
PR Assignees: pshipton, llxia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@llxia llxia

Labels
comp:test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-enable jdk_jmx for openj9 llxia/aqa-tests
2 participants
@pshipton @llxia