-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable openjdk test - jdk_bean #20531
Comments
Issue Number: 20531 |
@annaibm could you run the test on all platforms? Thanks |
|
The failure on jdk8 is already resolved via ibmruntimes/openj9-openjdk-jdk8#780 @babsingh pls take a look at the jdk11 failures. |
Thanks @pshipton With the latest JDK8, the
|
- Enable jck_beans on xlinux except for java version 8 and 11 related: eclipse-openj9/openj9#20531 Signed-off-by: Anna Babu Palathingal <[email protected]>
OpenJ9 JDK8 and JDK11 currently use OpenJ9 MethodHandles. Enabling jdk_bean in JDK8 and JDK11 triggers certain OpenJDK MethodHandles code paths. However, OpenJ9 MethodHandles are in use for JDK8 and JDK11, so OpenJDK MethodHandles paths shouldn't be activated. To address this, a MethodHandleImpl stub was added, used only with OpenJ9 MethodHandles, and not when OpenJDK MethodHandles are enabled. Related: eclipse-openj9#20531 Signed-off-by: Babneet Singh <[email protected]>
- Enable jck_beans on xlinux except for java version 8 and 11 related: eclipse-openj9/openj9#20531 Signed-off-by: Anna Babu Palathingal <[email protected]>
OpenJ9 JDK8 and JDK11 currently use OpenJ9 MethodHandles. Enabling jdk_bean in JDK8 and JDK11 triggers certain OpenJDK MethodHandles code paths. However, OpenJ9 MethodHandles are in use for JDK8 and JDK11, so OpenJDK MethodHandles paths shouldn't be activated. To address this, a MethodHandleImpl stub was added, used only with OpenJ9 MethodHandles, and not when OpenJDK MethodHandles are enabled. Related: eclipse-openj9#20531 Signed-off-by: Babneet Singh <[email protected]>
- Enable jdk_beans on xlinux except for java version 8 and 11 related: eclipse-openj9/openj9#20531 Signed-off-by: Anna Babu Palathingal <[email protected]>
- Enable jdk_beans on xlinux except for java version 8 and 11 related: eclipse-openj9/openj9#20531 Signed-off-by: Anna Babu Palathingal <[email protected]>
- Enable jdk_beans on xlinux except for java version 8 and 11 related: eclipse-openj9/openj9#20531 Signed-off-by: Anna Babu Palathingal <[email protected]>
- Enable jdk_beans on xlinux except for java version 8 and 11 related: eclipse-openj9/openj9#20531 Signed-off-by: Anna Babu Palathingal <[email protected]>
- Enable jdk_beans on xlinux for all java versions related: eclipse-openj9/openj9#20531 Signed-off-by: Anna Babu Palathingal <[email protected]>
- Enable jdk_beans on xlinux for all java versions related: eclipse-openj9/openj9#20531 Signed-off-by: Anna Babu Palathingal <[email protected]>
|
@dmitripivkine pls take a look at the jdk8 failure. |
@babsingh pls take a look at the jdk11 xmac failure:
|
There are some JIT asserts on xmac jdk21, which matches #20267
|
re #20531 (comment): JDK11 xmac failures have already been fixed via #20570, which was merged 2 days ago. The grinder uses a JDK with changes only till 7 Nov 24 and doesn't include the fix. Using a newer JDK, which includes the fix, should resolve the issue.
|
Regarding OOM case for Test5102804:
This allocation has failed because neither Tenure nor Nursery can take this object. OpenJ9 currently does not support expanding Tenure over Nursery (particularly for fully expanded heap |
@dmitripivkine I think the OOM is intentional. The test catches the OOM and checks if a Reference has been freed. |
Ok, thanks, I missed it. Do we know which Reference it is watching? |
- Exclude jdk_beans subtests as excluded in Adoptium related: eclipse-openj9/openj9#20531 Signed-off-by: Anna Babu Palathingal <[email protected]>
- Exclude jdk_beans subtests as excluded in Adoptium related: eclipse-openj9/openj9#20531 Signed-off-by: Anna Babu Palathingal <[email protected]>
Testing jdk_beans on xmac on openj9 Jenkins: https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/4013/ |
- Exclude jdk_beans subtests for OpenJ9 related: eclipse-openj9/openj9#20531 Signed-off-by: Anna Babu Palathingal <[email protected]>
jdk_beans failed in Test_openjdk8_j9_extended.openjdk_x86-64_linux:
@annaibm please exclude these two subtests on xlinux JDK8 for now. |
Note: |
- Exclude jdk_beans subtests for OpenJ9 related: eclipse-openj9/openj9#20531 Signed-off-by: Anna Babu Palathingal <[email protected]>
- Exclude jdk_bean subtest `java_awt_ScrollPane` - The test exclusion on macOS for versions 8,17,21,23 related: eclipse-openj9/openj9#20531 Signed-off-by: Anna Babu Palathingal <[email protected]>
https://github.com/ibmruntimes/openj9-openjdk-jdk8/blob/608c7b0e04732769340d9f44a5e342956df5fc85/jdk/test/java/beans/PropertyEditor/Test6397609.java#L36-L42 |
- Exclude jdk_bean subtest `java_awt_ScrollPane` - The test exclusion on macOS for versions 8,17,21,23 related: eclipse-openj9/openj9#20531 Signed-off-by: Anna Babu Palathingal <[email protected]>
- Exclude jdk_bean subtest -`Test6397609`,`Test5102804` on xlinux JDK8. related: eclipse-openj9/openj9#20531 Signed-off-by: Anna Babu Palathingal <[email protected]>
- Exclude jdk_bean subtest `java_awt_ScrollPane` - The test exclusion on macOS for versions 8,17,21,23 related: eclipse-openj9/openj9#20531 Signed-off-by: Anna Babu Palathingal <[email protected]>
- Exclude jdk_bean subtest -`Test6397609`,`Test5102804` on xlinux JDK8. related: eclipse-openj9/openj9#20531 Signed-off-by: Anna Babu Palathingal <[email protected]>
- Exclude jdk_bean subtest -`Test6397609` and ` Test5102804` on xlinux JDK8 related: eclipse-openj9/openj9#20531 Signed-off-by: Anna Babu Palathingal <[email protected]>
The following jdk_beans subtests fail consistently on xmac platform for JDK versions 8, 11, 17, 21, and 23:
All the subtests fail with the same error:
Note: The subtests passed on openj9 Grinder :4013 |
- Exclude jdk_bean subtest `java_awt_ScrollPane` - The test exclusion on macOS for versions 8,17,21,23 related: eclipse-openj9/openj9#20531 Signed-off-by: Anna Babu Palathingal <[email protected]>
- Exclude jdk_bean subtest -`Test6397609` and ` Test5102804` on xlinux JDK8 related: eclipse-openj9/openj9#20531 Signed-off-by: Anna Babu Palathingal <[email protected]>
- Exclude jdk_bean subtest -`Test6397609` and ` Test5102804` on xlinux JDK8 related: eclipse-openj9/openj9#20531 Signed-off-by: Anna Babu Palathingal <[email protected]>
- Exclude jdk_bean subtest -`Test6397609` and ` Test5102804` on xlinux JDK8 related: eclipse-openj9/openj9#20531 Signed-off-by: Anna Babu Palathingal <[email protected]>
- Exclude jdk_bean subtest -`Test6397609` and ` Test5102804` on xlinux JDK8 related: eclipse-openj9/openj9#20531 Signed-off-by: Anna Babu Palathingal <[email protected]>
- Exclude jdk_bean subtest -`Test6397609` and ` Test5102804` on xlinux JDK8 related: eclipse-openj9/openj9#20531 Signed-off-by: Anna Babu Palathingal <[email protected]>
- Enable jdk_beans on alinux, plinux, slinux for all java versions related: eclipse-openj9/openj9#20531 Signed-off-by: Anna Babu Palathingal <[email protected]>
- Enable jdk_beans on alinux, plinux, slinux for all java versions related: eclipse-openj9/openj9#20531 Signed-off-by: Anna Babu Palathingal <[email protected]>
- Enable jdk_beans on alinux, plinux, slinux for all java versions related: eclipse-openj9/openj9#20531 Signed-off-by: Anna Babu Palathingal <[email protected]>
jdk_beans got excluded as part of the general exclude a while back via #10757.
https://github.com/adoptium/aqa-tests/blob/a498becc695f7bdeaa7c4b3752c827e65aa7e123/openjdk/playlist.xml#L755
My limited testing can pass on xlinux JDK17, 21 and 23. We still need to look into xlinux JDK8 and JDK11 failures. But I think we should look into re-enabling this test.
This would help us to discover issues like https://bugs.openjdk.org/browse/JDK-8336862 early.
Presumably, we will hit the same issue on Windows: adoptium/aqa-tests#5690 (comment)
The text was updated successfully, but these errors were encountered: