Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Valhalla: update and consolidate tests with null-restricted javac support #20268

Open
theresa-m opened this issue Oct 1, 2024 · 3 comments
Open

Valhalla: update and consolidate tests with null-restricted javac support #20268

theresa-m opened this issue Oct 1, 2024 · 3 comments
Labels
comp:test project:valhalla Used to track Project Valhalla related work

Comments

@theresa-m
Copy link
Contributor

Once javac has support for null-restricted fields the Valhalla tests will need to be updated by either transitioning from src_qtypes to src_lw5 tests. It hasn't been possible since the last extensions update to run OpenJ9 with src_lw5 tests since the OpenJDK lw5 branch I was using before still relies on the ACC_VALUE flag. Before transitioning any updates that have recently been made to the src_qtypes tests will need to be added to src_lw5.

fyi @hangshao0
@theresa-m theresa-m added project:valhalla Used to track Project Valhalla related work comp:test labels Oct 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024

Issue Number: 20268
Status: Open
Recommended Components: comp:test, comp:vm, comp:build
Recommended Assignees: hangshao0, theresa-m, keithc-ca

@theresa-m theresa-m mentioned this issue Oct 1, 2024
Draft
@theresa-m
Copy link
Contributor Author

#18558 was previously opened to track some of this work.

@theresa-m
Copy link
Contributor Author

https://github.com/eclipse-openj9/openj9/pull/20250/files#diff-d12d08021421d66e60440fb1e3bd9aca17ee85d1f3cd9402eac772d96f7a1ca4R123 is also related.

theresa-m added a commit to theresa-m/openj9 that referenced this issue Nov 1, 2024
@theresa-m
Label disabled NullRestrictedTypeOptTests
294d74f 
These tests cannot be expressed without an lw5 level javac. These
 will be enabled when tests are migrated to the src_lw5 versions
 which is related to eclipse-openj9#20268.

Signed-off-by: Theresa Mammarella <[email protected]>
theresa-m added a commit to theresa-m/openj9 that referenced this issue Nov 1, 2024
@theresa-m
Label disabled NullRestrictedTypeOptTests
6f8abd9 
These tests cannot be expressed without an lw5 level javac. These
 will be enabled when tests are migrated to the src_lw5 versions
 which is related to eclipse-openj9#20268.

Signed-off-by: Theresa Mammarella <[email protected]>
zl-wang pushed a commit to zl-wang/openj9 that referenced this issue Nov 11, 2024
@theresa-m @zl-wang
Label disabled NullRestrictedTypeOptTests
b608732 
These tests cannot be expressed without an lw5 level javac. These
 will be enabled when tests are migrated to the src_lw5 versions
 which is related to eclipse-openj9#20268.

Signed-off-by: Theresa Mammarella <[email protected]>
ThanHenderson pushed a commit to ThanHenderson/openj9 that referenced this issue Nov 25, 2024
@theresa-m @ThanHenderson
Label disabled NullRestrictedTypeOptTests
3e23265 
These tests cannot be expressed without an lw5 level javac. These
 will be enabled when tests are migrated to the src_lw5 versions
 which is related to eclipse-openj9#20268.

Signed-off-by: Theresa Mammarella <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp:test project:valhalla Used to track Project Valhalla related work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@theresa-m