Transform new converter call to arraytranslate node #7247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging @r30shah @hzongaro @vijaysun-omr for review. |
hzongaro
reviewed
Feb 7, 2024
There was a problem hiding this comment.
I think the changes look good, though I will defer to @r30shah for a more thorough review.
May I ask you to add a little more detail to the commit message? Other than that suggestion, I have just a couple of cosmetic comments.
r30shah
suggested changes
Feb 7, 2024
|
@zl-wang and @knn-k / @Akira1Saitoh fyi |
|
AArch64 codegen does not implement arraytranslate now. Issue #6092. |
dchopra001
force-pushed
the
accelImplEncodeAscii
branch
2 times, most recently
from
3d75239 to
08ce7c0
Compare
r30shah
approved these changes
Feb 12, 2024
dchopra001
force-pushed
the
accelImplEncodeAscii
branch
from
08ce7c0 to
81f30e4
Compare
hzongaro
reviewed
Feb 15, 2024
StringCoding.implEncodeAsciiArray is a renamed version of US_ASCII/Encoder.encodeASCII, which is a recognized method. This commit introduces infrastructure to enable inlining of implEncodeAsciiArray like it is done for encodeASCII.
dchopra001
force-pushed
the
accelImplEncodeAscii
branch
from
81f30e4 to
7c2e3e1
Compare
|
Jenkins build all |
|
x86-64 macOS test failure is due to known issue #7181 |
|
OMR testing was successful, other than failures due to known issues. Downstream OpenJ9 testing with this change was also successful. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StringCoding.implEncodeAsciiArrayis nearly identical in implementation and use case to the oldUS_ASCII/Encoder.encodeASCIImethod. This PR adds support in VP for transformingStringCoding.implEncodeAsciiArrayinto anarraytranslatethat can then be take advantage of pre-existing acceleration for this workload.