-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce universal configuration provider #835
Conversation
See attached implementation for wildwebdeveloper. After this, for example vue language server (because support didChangeConfiguration auto-registration) without any other modification will be able to consume js/ts settings managed by eclipse |
0b427eb
to
3c6b79a
Compare
3c6b79a
to
bf091d9
Compare
@angelozerr @mickaelistria any comments? |
I will try to review it soon |
knock knock ;) |
I think the part adding "didChangeConfiguration auto registration" is good and due to properly support LSP. |
Sure, I had a plan to maybe in future implement default provider for "proxy.*" configs, but even they don't use IEclipsePreference ;) |
The initial target branch |
This pr implements: