Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Question] Handling of space at end of line when contributing code #1110

Open
ahus1 opened this issue Dec 23, 2024 · 0 comments · May be fixed by #1111
Open

[Question] Handling of space at end of line when contributing code #1110

ahus1 opened this issue Dec 23, 2024 · 0 comments · May be fixed by #1111
Labels
question Request for support in using ELK.

Comments

@ahus1
Copy link

ahus1 commented Dec 23, 2024

Ask your questions

I was preparing a contribution for LayoutMetaDataService.java in https://github.com/eclipse-elk/elk/pull/1109/files using IntelliJ, and I found that my IDE stripped a lot of blanks at the end of the line.

Expected behavior

No blank at the end of the line, or a configuration that prevents my IDE to remove them.

Additional context

Something line this can be configured on a per-project specific setting via an .editorconfig. I'll suggest one that worked for me in a PR shortly.
@ahus1 ahus1 added the question Request for support in using ELK. label Dec 23, 2024
@ahus1 ahus1 changed the title [Question] Handling of space at end of line [Question] Handling of space at end of line when contributing code Dec 23, 2024
@ahus1 ahus1 linked a pull request Dec 23, 2024 that will close this issue
Open
ahus1 added a commit to ahus1/elk that referenced this issue Dec 23, 2024
@ahus1
Keep whitespace in files to prevent unintended changes in PRs (eclips…
6d0239f 
…e-elk#1110)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Request for support in using ELK.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Keep whitespace in files to prevent unintended changes in PRs ahus1/elk
1 participant
@ahus1