-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Micrometer Observation support #5371
Comments
It's worth mentioning that we already have such instrumentation in Micrometer and we would be happy to donate it to this project and help maintain it in the future |
Hi @marcingrzejszczak, As you can see, we have some MicroProfile extensions, I can imagine having Micrometer extensions in the How can we help you with the PR? Are there any details you would like to discuss? |
code got ported from Micrometer 1.10.9 and contains metrics and observation listeners related issue: eclipse-ee4j#5371
code got ported from Micrometer 1.10.9 and contains metrics and observation listeners related issue: eclipse-ee4j#5371
Sorry for the delay - I was on PTO. #5391 this is a PR that basically has the port of what we currently have in Micrometer. It has tests for metrics and observability listeners. This is an example of how the trace looks like from the point of view of the server |
code got ported from Micrometer 1.10.9 and contains metrics and observation listeners related issue: eclipse-ee4j#5371 Signed-off-by: Marcin Grzejszczak <[email protected]>
code got ported from Micrometer 1.10.9 and contains metrics and observation listeners related issue: eclipse-ee4j#5371 Signed-off-by: Marcin Grzejszczak <[email protected]>
code got ported from Micrometer 1.10.9 and contains metrics and observation listeners related issue: eclipse-ee4j#5371 Signed-off-by: Marcin Grzejszczak <[email protected]>
I'm a co-maintainer of Spring Cloud Sleuth and Micrometer projects (together with @shakuzen and @jonatan-ivanov).
Micrometer Observation is part of the Micrometer 1.10 release and Micrometer Tracing is a new project. The idea of Micrometer Observation is that you instrument code once but you get multiple benefits out of it - e.g. you can get tracing, metrics, logging or whatever you see fit).
Since this project already records metrics I was curious if there's interest in adding Micrometer Observation support so that except for metrics, spans could be created and tracing context propagation could happen too. Via Micrometer Tracing one can use OpenTelemetry or OpenZipkin Brave Tracer, but with the handler mechanism the possibilities are endless :)
If there's such interest we could provide a PR to add support for that.
The text was updated successfully, but these errors were encountered: