Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MailHandler should catch ServiceConfigurationError #123

Closed
jmehrens opened this issue Jan 25, 2024 · 1 comment · Fixed by #125
Closed

MailHandler should catch ServiceConfigurationError #123

jmehrens opened this issue Jan 25, 2024 · 1 comment · Fixed by #125
Assignees
Labels
bug Something isn't working

Comments

@jmehrens
Copy link
Contributor

jmehrens commented Jan 25, 2024

Source issue for this ticket is: jakartaee/mail-api#548

The idea of this ticket is that the MailHandler should not allow ServiceConfigurationError escape into the calling thread causing a fatal crash. Instead the MailHandler should catch this error and redirect it to the error manager.

In Angus Mail (currently) the session will no longer throw ServiceConfigurationError but will instead throw an lllegalStateException wrapping the service configuration error. So while this is fixed for Angus Mail, the MailHandler must be patched to handle this error because the MailHandler can be used with the logging-mailhandler artifact which can bind to other implementations or older Angus Mail implementations that may throw ServiceConfigurationError directly.

This patch will also handle possible IllegalStateException and ServiceConfigurationError from the jaf-api and implementations of jaf-api such as angus activation.

@jmehrens jmehrens added the bug Something isn't working label Jan 25, 2024
@jmehrens jmehrens self-assigned this Jan 25, 2024
jmehrens added a commit to jmehrens/angus-mail that referenced this issue Jan 29, 2024
jmehrens added a commit to jmehrens/angus-mail that referenced this issue Jan 30, 2024
@jmehrens jmehrens linked a pull request Jan 30, 2024 that will close this issue
jmehrens added a commit to jmehrens/angus-mail that referenced this issue Jan 30, 2024
jmehrens added a commit to jmehrens/angus-mail that referenced this issue Jan 30, 2024
jmehrens added a commit to jmehrens/angus-mail that referenced this issue Jan 30, 2024
jmehrens added a commit to jmehrens/angus-mail that referenced this issue Jan 31, 2024
@jmehrens jmehrens changed the title MailHander should catch ServiceConfigurationError MailHandler should catch ServiceConfigurationError Jan 31, 2024
jmehrens added a commit to jmehrens/angus-mail that referenced this issue Jan 31, 2024
jmehrens added a commit to jmehrens/angus-mail that referenced this issue Feb 1, 2024
jmehrens added a commit to jmehrens/angus-mail that referenced this issue Feb 1, 2024
jmehrens added a commit to jmehrens/angus-mail that referenced this issue Feb 1, 2024
jmehrens added a commit to jmehrens/angus-mail that referenced this issue Feb 1, 2024
jmehrens added a commit to jmehrens/angus-mail that referenced this issue Feb 2, 2024
jmehrens added a commit to jmehrens/angus-mail that referenced this issue Feb 2, 2024
jmehrens added a commit that referenced this issue Feb 14, 2024
MailHander should catch ServiceConfigurationError #123 
Signed-off-by: jmehrens <[email protected]>
@jmehrens
Copy link
Contributor Author

Committed to 2.0.3 as 181d10d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant