Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve the GitHub Server subdomain isolation config description #2667

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

vinokurig
Copy link
Contributor

What does this pull request change?

improve the GitHub Server subdomain isolation config description:
screenshot-0 0 0 0_4000-2023 11 29-15_43_48

What issues does this pull request fix or reference?

fixes eclipse-che/che#22699

Specify the version of the product this pull request applies to

3.11

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
    • The page contains a redirection for the previous URL.
    • Propagate the URL change in:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

@vinokurig vinokurig requested review from deerskindoll and a team as code owners November 29, 2023 13:44
@vinokurig vinokurig requested a review from ibuziuk November 29, 2023 13:44
Copy link

github-actions bot commented Nov 29, 2023

🎊 Navigate the preview: https://6568442fd4d40f7bf7350c7f--eclipse-che-docs-pr.netlify.app 🎊

Copy link

github-actions bot commented Nov 29, 2023

Click here to review and test in web IDE: Contribute

Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed link and a small edit

@vinokurig
Copy link
Contributor Author

@deerskindoll I have fixed your suggestion, could you please review the PR again?

Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ibuziuk ibuziuk merged commit 38ba74e into main Nov 30, 2023
7 checks passed
@ibuziuk ibuziuk deleted the che-22699 branch November 30, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Improve the documentation about configuring GitHub server with subdomain isolation
4 participants