Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add CONTRIBUTING.md #919

Merged
merged 10 commits into from
Sep 21, 2023
Merged

chore: add CONTRIBUTING.md #919

merged 10 commits into from
Sep 21, 2023

Conversation

akurinnoy
Copy link
Contributor

What does this PR do?

Add the CONTRIBUTING.md file.

What issues does this PR fix or reference?

eclipse-che/che#22243

@openshift-ci
Copy link

openshift-ci bot commented Sep 12, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@che-bot
Copy link
Contributor

che-bot commented Sep 12, 2023

Click here to review and test in web IDE: Contribute

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #919 (c7513de) into main (481cd3e) will decrease coverage by 0.03%.
Report is 5 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #919      +/-   ##
==========================================
- Coverage   82.29%   82.26%   -0.03%     
==========================================
  Files         350      351       +1     
  Lines       36752    36799      +47     
  Branches     2357     2356       -1     
==========================================
+ Hits        30245    30274      +29     
- Misses       6483     6501      +18     
  Partials       24       24              
Flag Coverage Δ
unittests 82.26% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 10 files with indirect coverage changes

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-919

@ibuziuk ibuziuk requested a review from dkwon17 September 12, 2023 13:43
@akurinnoy akurinnoy marked this pull request as ready for review September 13, 2023 07:45
Copy link
Member

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-919

@openshift-ci openshift-ci bot removed the lgtm label Sep 13, 2023
@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-919

Copy link
Contributor

@dkwon17 dkwon17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some suggestions, looks great

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
Co-authored-by: David Kwon <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm label Sep 20, 2023
akurinnoy and others added 5 commits September 20, 2023 12:44
Co-authored-by: David Kwon <[email protected]>
Co-authored-by: David Kwon <[email protected]>
Co-authored-by: David Kwon <[email protected]>
Co-authored-by: David Kwon <[email protected]>
Co-authored-by: David Kwon <[email protected]>
@openshift-ci
Copy link

openshift-ci bot commented Sep 20, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, dkwon17, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@akurinnoy akurinnoy merged commit 8d29c17 into main Sep 21, 2023
11 of 12 checks passed
@akurinnoy akurinnoy deleted the contributing branch September 21, 2023 14:54
@devstudio-release
Copy link

Build 3.10 :: dashboard_3.x/342: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.10 :: dashboard_3.x/343: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.10 :: dashboard_3.x/343: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/4708 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.10 :: dashboard_3.x/342: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/4707 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.10 :: update-digests_3.x/4371: UNSTABLE

No new images detected: nothing to do!

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.10 :: update-digests_3.x/4372: UNSTABLE

No new images detected: nothing to do!

@devstudio-release
Copy link

Build 3.10 :: dashboard_3.x/344: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.10 :: dashboard_3.x/344: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/4754 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.10 :: update-digests_3.x/4417: UNSTABLE

No new images detected: nothing to do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants