Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple timeline-chart API and login from it's usage with theia-trace-extension #256

Open
bhufmann opened this issue May 26, 2023 · 0 comments

Comments

@bhufmann
Copy link
Collaborator

The timeline-chart library is intended to visualize timegraph data where the timegraph data can lazily loaded. For that the parent component will provide call backs to provide the data. The theia-trace-extenstion is one of the main user of the timeline-chart. To optimize the performance of loading the data certain mechanism have been implemented (main method of concern:

protected async maybeFetchNewData(update?: boolean, fine?: boolean) {
):

These optimizations where to due to the way the theia-trace-extensions fetches the data. However, such logic should not be inside the timeline-chart library, it should be handled in the component that uses it. The 'timeline-chart' should just display the model that is provided by the user component independent to if the data is collected in steps.

Due the tight coupling it will be harder and harder adding features and performance improvement to the timeline-chart library.

This tracker is to track the decoupling task that will extract theia-trace-extension specific logic and move it to the theia-trace-extension. It is expected that it will change the API of the timeline-chart library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant