[ci] Use GitHub token to avoid ripgrep download issue #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcdumais-work
force-pushed
the
ci-use-github_token
branch
3 times, most recently
from
174593a to
75b1e31
Compare
In a recent CI run, I noticed this error: "Downloading ripgrep failed: Error: Request failed: 403" This happens because of GitHub has limits when anonymously accessing its API, which we do when downloading ripgrep. There's an easy fix: use an auto-generated GitHub token when building the Theia app. Also tidied-up the workflow file a little, to make it easier to read. Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work
force-pushed
the
ci-use-github_token
branch
from
75b1e31 to
9d70b88
Compare
|
While in there, I have cleaned-up the labels used for the workflow, i.e. its name and the jobs and step names. I think it will look nicer in the PR "checks" section and also in the detailed |
bhufmann
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a recent CI run, I noticed this error:
"Downloading ripgrep failed: Error: Request failed: 403"
This can randomly happen on CI machines, because GitHub has limits when anonymously accessing its API, which we do when downloading
ripgrep. There's an easy fix: use an auto-generated GitHub token when building the Theia app.Also tidied-up the workflow file a little, to make it easier to read.