Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make example applications more like trace viewer appliances #1072

Open
marcdumais-work opened this issue Apr 26, 2024 · 0 comments
Open

Make example applications more like trace viewer appliances #1072

marcdumais-work opened this issue Apr 26, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@marcdumais-work
Copy link
Contributor

marcdumais-work commented Apr 26, 2024

In #1071, we removed content from the example applications, that's not deemed necessary for using these apps for the purpose of testing in this repo. Since we use the example apps to test the "theia trace extension", they did not need to have extra features, like support running vscode extensions. This makes for leaner apps, that build quicker, so quicker CI, etc.

If it's desired to make the test apps (or other Theia apps that use "theia trace extension") even more appliance-like, it would be possible to remove some unneeded Theia framework contributions, like the problems and outline views, as well as e.g. menu entries that do not bring much value for a trace viewer appliance.

One way to do so would be to use Theia's "registerContributionFilters", like in this example from Vincent F:
https://github.com/vince-fugnitto/theia-no-debug/blob/master/no-debug/src/browser/no-debug-contribution.ts

This filtering would not be suitable for the case where the Theia trace extension is used in a full-fledge IDE, only for an appliance. As such, the filterring would need to be done in a separate Theia extension, that would only be included in appliances. e.g. named something like "trace-viewer-appliance".

Some potential items:

  • have the trace viewer expanded at startup (equivalent to when clicking on the left-panel "Trace Viewer" entry
  • Programmatically remove remaining un-needed Theia framework contributions:
    • Problems view
    • Outline view
    • misc menus/menu entries
    • etc...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant