From 9c13457dc740e729957aa3deb0869a1092efe7e8 Mon Sep 17 00:00:00 2001 From: Marc Dumais Date: Mon, 11 Mar 2024 11:02:56 -0400 Subject: [PATCH] [CI] [playwright] Run UI tests on the browser app Since we have this minimal UI test suite, let's also use it on the browser example app. Signed-off-by: Marc Dumais --- .github/workflows/build.yml | 7 ++++++- playwright-tests/tests/trace-viewer-app.test.ts | 1 + 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 91b1e595..d687fba9 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -48,11 +48,16 @@ jobs: env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # https://github.com/microsoft/vscode-ripgrep/issues/9 - - name: Test + - name: Run Unit Tests run: yarn test env: CI: true + - name: Run UI tests on Browser Example App + run: + yarn start:browser & + yarn test:browser-app + code-lint: name: Lint and check format runs-on: ubuntu-latest diff --git a/playwright-tests/tests/trace-viewer-app.test.ts b/playwright-tests/tests/trace-viewer-app.test.ts index 485446a4..c2906125 100644 --- a/playwright-tests/tests/trace-viewer-app.test.ts +++ b/playwright-tests/tests/trace-viewer-app.test.ts @@ -71,6 +71,7 @@ test.describe('My Trace Explorer View', () => { test('From closed, can be re-opened using the command palette', async () => { expect(await traceExplorer.isDisplayed()).toBe(false); await traceExplorer.open(); + await traceExplorer.activate(); expect(await traceExplorer.isDisplayed()).toBe(true); }); test('Trace Server status is shown as not started (red)', async () => {