Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing navigation of associations in CDB diagram recreates them modifying original layout or hiding them in unsynchronized mode #2913

Open
scosta-obeo opened this issue Nov 6, 2024 · 0 comments

Comments

@scosta-obeo
Copy link
Contributor

Step to reproduce:

  • Create CDB Diagram
  • Create 2 classes and an association between them
  • Create a bendpoint on the association edge
  • In the property view, make the association navigable in both directions (by checking the checkbox "Is Navigable" which is unchecked)
  • Expected: the edge is always visible and it has the same bendpoints
  • Actuel: the bendpoints are reset (synchronized mode) or the edge disappears (unsynchronized mode)
scosta-obeo added a commit to scosta-obeo/capella that referenced this issue Nov 6, 2024
This commit merge two command for navigability state of association in
CDB to avoid diagram refresh (and unwanted behavior) between them.

Signed-off-by: Séraphin Costa <[email protected]>
scosta-obeo added a commit to scosta-obeo/capella that referenced this issue Nov 6, 2024
This commit make association source and target reliable in CDB always
have the same source and target and to prevent a change in property from
changing the source or the target.

This commit also add migration to reverse the association edge in the
wrong direction in old project.

Signed-off-by: Séraphin Costa <[email protected]>
scosta-obeo added a commit to scosta-obeo/capella that referenced this issue Nov 6, 2024
scosta-obeo added a commit to scosta-obeo/capella that referenced this issue Nov 6, 2024
This commit make association source and target reliable in CDB always
have the same source and target and to prevent a change in property from
changing the source or the target.

This commit also add migration to reverse the association edge in the
wrong direction in old project.

Signed-off-by: Séraphin Costa <[email protected]>
scosta-obeo added a commit to scosta-obeo/capella that referenced this issue Nov 6, 2024
scosta-obeo added a commit to scosta-obeo/capella that referenced this issue Nov 7, 2024
scosta-obeo added a commit to scosta-obeo/capella that referenced this issue Nov 7, 2024
scosta-obeo added a commit to scosta-obeo/capella that referenced this issue Nov 7, 2024
scosta-obeo added a commit to scosta-obeo/capella that referenced this issue Nov 7, 2024
scosta-obeo added a commit to scosta-obeo/capella that referenced this issue Nov 12, 2024
This commit merges two commands for navigability state of association in
CDB to avoid diagram refresh (and unwanted behaviour) between them.

Signed-off-by: Séraphin Costa <[email protected]>
scosta-obeo added a commit to scosta-obeo/capella that referenced this issue Nov 12, 2024
This commit makes association source and target reliable in CDB, to
always have the same source and target, and to prevent a change in
property from changing the source or the target.

This commit also adds a migration to reverse the association edge in the
wrong direction in existing projects.

Signed-off-by: Séraphin Costa <[email protected]>
scosta-obeo added a commit to scosta-obeo/capella that referenced this issue Nov 12, 2024
scosta-obeo added a commit to scosta-obeo/capella that referenced this issue Nov 12, 2024
scosta-obeo added a commit to scosta-obeo/capella that referenced this issue Nov 13, 2024
This commit update the CDB association edge mapping in the VSM
(source/target mappings and styles) to makes association source and
target reliable in CDB, to always have the same source and target, and
to prevent a change in property from changing the source or the target.

This commit also adds a migration to reverse the association edge in the
wrong direction in existing projects.

Signed-off-by: Séraphin Costa <[email protected]>
scosta-obeo added a commit to scosta-obeo/capella that referenced this issue Nov 13, 2024
scosta-obeo added a commit to scosta-obeo/capella that referenced this issue Nov 13, 2024
scosta-obeo added a commit to scosta-obeo/capella that referenced this issue Nov 13, 2024
This commit updates the CDB association edge mapping in the VSM
(source/target mappings and styles) to makes association source and
target reliable in CDB, to always have the same source and target, and
to prevent a change in property from changing the source or the target.

This commit also adds a migration to reverse the association edge in the
wrong direction in existing projects.

Signed-off-by: Séraphin Costa <[email protected]>
scosta-obeo added a commit to scosta-obeo/capella that referenced this issue Nov 13, 2024
scosta-obeo added a commit to scosta-obeo/capella that referenced this issue Nov 13, 2024
scosta-obeo added a commit to scosta-obeo/capella that referenced this issue Nov 13, 2024
This commit updates the CDB association edge mapping in the VSM
(source/target mappings and styles) to make association source and
target reliable in CDB, to always have the same source and target, and
to prevent a change in property from changing the source or the target.

This commit also adds a migration to reverse the association edge in the
wrong direction in existing projects.

Signed-off-by: Séraphin Costa <[email protected]>
scosta-obeo added a commit to scosta-obeo/capella that referenced this issue Nov 13, 2024
scosta-obeo added a commit to scosta-obeo/capella that referenced this issue Nov 13, 2024
scosta-obeo added a commit to scosta-obeo/capella that referenced this issue Nov 21, 2024
This commit updates the CDB association edge mapping in the VSM
(source/target mappings and styles) to make association source and
target reliable in CDB, to always have the same source and target, and
to prevent a change in property from changing the source or the target.

This commit also adds a migration to reverse the association edge in the
wrong direction in existing projects.

Signed-off-by: Séraphin Costa <[email protected]>
scosta-obeo added a commit to scosta-obeo/capella that referenced this issue Nov 21, 2024
scosta-obeo added a commit to scosta-obeo/capella that referenced this issue Nov 21, 2024
scosta-obeo added a commit to scosta-obeo/capella that referenced this issue Nov 26, 2024
This commit updates the CDB association edge mapping in the VSM
(source/target mappings and styles) to make association source and
target reliable in CDB, to always have the same source and target, and
to prevent a change in property from changing the source or the target.

This commit also adds a migration to reverse the association edge in the
wrong direction in existing projects.

Signed-off-by: Séraphin Costa <[email protected]>
scosta-obeo added a commit to scosta-obeo/capella that referenced this issue Nov 26, 2024
scosta-obeo added a commit to scosta-obeo/capella that referenced this issue Nov 26, 2024
scosta-obeo added a commit to scosta-obeo/capella that referenced this issue Nov 28, 2024
This commit updates the CDB association edge mapping in the VSM
(source/target mappings and styles) to make association source and
target reliable in CDB, to always have the same source and target, and
to prevent a change in property from changing the source or the target.

This commit also adds a migration to reverse the association edge in the
wrong direction in existing projects.

This commit also adapts the tests
ReconnectRelationshipGroup.ReconnectRelationshipGroupSA,
ReconnectRelationshipGroup.ReconnectRelationshipGroupOA in
org.polarsys.capella.test.diagram.tools.ju.cdb to these changes.

Signed-off-by: Séraphin Costa <[email protected]>
scosta-obeo added a commit to scosta-obeo/capella that referenced this issue Nov 28, 2024
scosta-obeo added a commit to scosta-obeo/capella that referenced this issue Nov 28, 2024
This commit also:

* Revert some unexpected changes (data intentionally corrupted for test
Rule_I_43_ElementReferencesAirdOrProxyElement)

* Adapt tests HideAssociationLabels, HideRoleNames and ShowModifiers
because the source and target have been inverted and therefore also the
labels.

Signed-off-by: Séraphin Costa <[email protected]>
scosta-obeo added a commit to scosta-obeo/capella that referenced this issue Nov 28, 2024
This commit updates the CDB association edge mapping in the VSM
(source/target mappings and styles) to make association source and
target reliable in CDB, to always have the same source and target, and
to prevent a change in property from changing the source or the target.

This commit also adds a migration to reverse the association edge in the
wrong direction in existing projects.

This commit also adapts the tests
ReconnectRelationshipGroup.ReconnectRelationshipGroupSA,
ReconnectRelationshipGroup.ReconnectRelationshipGroupOA in
org.polarsys.capella.test.diagram.tools.ju.cdb to these changes.

Signed-off-by: Séraphin Costa <[email protected]>
scosta-obeo added a commit to scosta-obeo/capella that referenced this issue Nov 28, 2024
scosta-obeo added a commit to scosta-obeo/capella that referenced this issue Nov 28, 2024
This commit also:

* Revert some unexpected changes (data intentionally corrupted for test
Rule_I_43_ElementReferencesAirdOrProxyElement)

* Adapt tests HideAssociationLabels, HideRoleNames and ShowModifiers
because the source and target have been inverted and therefore also the
labels.

Signed-off-by: Séraphin Costa <[email protected]>
scosta-obeo added a commit to scosta-obeo/capella that referenced this issue Nov 28, 2024
This commit merges two commands for navigability state of association in
CDB to avoid diagram refresh (and unwanted behaviour) between them.

Signed-off-by: Séraphin Costa <[email protected]>
scosta-obeo added a commit to scosta-obeo/capella that referenced this issue Nov 28, 2024
This commit updates the CDB association edge mapping in the VSM
(source/target mappings and styles) to make association source and
target reliable in CDB, to always have the same source and target, and
to prevent a change in property from changing the source or the target.

This commit also adds a migration to reverse the association edge in the
wrong direction in existing projects.

This commit also adapts the tests
ReconnectRelationshipGroup.ReconnectRelationshipGroupSA,
ReconnectRelationshipGroup.ReconnectRelationshipGroupOA in
org.polarsys.capella.test.diagram.tools.ju.cdb to these changes.

Signed-off-by: Séraphin Costa <[email protected]>
scosta-obeo added a commit to scosta-obeo/capella that referenced this issue Nov 28, 2024
scosta-obeo added a commit to scosta-obeo/capella that referenced this issue Nov 28, 2024
This commit also:

* Revert some unexpected changes (data intentionally corrupted for test
Rule_I_43_ElementReferencesAirdOrProxyElement)

* Adapt tests HideAssociationLabels, HideRoleNames and ShowModifiers
because the source and target have been inverted and therefore also the
labels.

Signed-off-by: Séraphin Costa <[email protected]>
scosta-obeo added a commit to scosta-obeo/capella that referenced this issue Nov 29, 2024
scosta-obeo added a commit to scosta-obeo/capella that referenced this issue Nov 29, 2024
This commit also:

* Revert some unexpected changes (data intentionally corrupted for test
Rule_I_43_ElementReferencesAirdOrProxyElement)

* Adapt tests HideAssociationLabels, HideRoleNames and ShowModifiers
because the source and target have been inverted and therefore also the
labels.

Signed-off-by: Séraphin Costa <[email protected]>
scosta-obeo added a commit to scosta-obeo/capella that referenced this issue Dec 2, 2024
This commit also:

* Revert some unexpected changes (data intentionally corrupted for test
Rule_I_43_ElementReferencesAirdOrProxyElement)

* Adapt tests HideAssociationLabels, HideRoleNames and ShowModifiers
because the source and target have been inverted and therefore also the
labels.

Signed-off-by: Séraphin Costa <[email protected]>
scosta-obeo added a commit to scosta-obeo/capella that referenced this issue Dec 3, 2024
This commit merges two commands for navigability state of association in
CDB to avoid diagram refresh (and unwanted behaviour) between them.

Signed-off-by: Séraphin Costa <[email protected]>
scosta-obeo added a commit to scosta-obeo/capella that referenced this issue Dec 3, 2024
This commit updates the CDB association edge mapping in the VSM
(source/target mappings and styles) to make association source and
target reliable in CDB, to always have the same source and target, and
to prevent a change in property from changing the source or the target.

This commit also adds a migration to reverse the association edge in the
wrong direction in existing projects.

This commit also adapts the tests
ReconnectRelationshipGroup.ReconnectRelationshipGroupSA,
ReconnectRelationshipGroup.ReconnectRelationshipGroupOA in
org.polarsys.capella.test.diagram.tools.ju.cdb to these changes.

Signed-off-by: Séraphin Costa <[email protected]>
scosta-obeo added a commit to scosta-obeo/capella that referenced this issue Dec 3, 2024
scosta-obeo added a commit to scosta-obeo/capella that referenced this issue Dec 3, 2024
This commit also:

* Revert some unexpected changes (data intentionally corrupted for test
Rule_I_43_ElementReferencesAirdOrProxyElement)

* Adapt tests HideAssociationLabels, HideRoleNames and ShowModifiers
because the source and target have been inverted and therefore also the
labels.

Signed-off-by: Séraphin Costa <[email protected]>
tguiu pushed a commit that referenced this issue Dec 4, 2024
This commit merges two commands for navigability state of association in
CDB to avoid diagram refresh (and unwanted behaviour) between them.

Signed-off-by: Séraphin Costa <[email protected]>
tguiu pushed a commit that referenced this issue Dec 4, 2024
This commit updates the CDB association edge mapping in the VSM
(source/target mappings and styles) to make association source and
target reliable in CDB, to always have the same source and target, and
to prevent a change in property from changing the source or the target.

This commit also adds a migration to reverse the association edge in the
wrong direction in existing projects.

This commit also adapts the tests
ReconnectRelationshipGroup.ReconnectRelationshipGroupSA,
ReconnectRelationshipGroup.ReconnectRelationshipGroupOA in
org.polarsys.capella.test.diagram.tools.ju.cdb to these changes.

Signed-off-by: Séraphin Costa <[email protected]>
tguiu pushed a commit that referenced this issue Dec 4, 2024
tguiu pushed a commit that referenced this issue Dec 4, 2024
This commit also:

* Revert some unexpected changes (data intentionally corrupted for test
Rule_I_43_ElementReferencesAirdOrProxyElement)

* Adapt tests HideAssociationLabels, HideRoleNames and ShowModifiers
because the source and target have been inverted and therefore also the
labels.

Signed-off-by: Séraphin Costa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant