Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing a session with a "vpd" editor opened will throw a ClassCastException #2886

Open
Kellindil opened this issue Jul 8, 2024 · 1 comment

Comments

@Kellindil
Copy link

Capella 6.1.0

  • Create a new capella projet (activity explorer opens automatically)
  • Open an editor on any vpd file ("PV Configuration Editor" from the PVMT add-on)
  • Right-click on the aird file and use "Close"

The following dialog pops up. The session is not closed. There is no associated stack trace, only that dialog.

image

@etraisnel2
Copy link
Contributor

etraisnel2 commented Jul 8, 2024

Seems like cases where VPDEditor is opened on a .vpd file isn't properly handled

in VirtualPvdEditor.notifySessionClosing (and more globally, all across PVMT code) , cases where input would be a FileEditorInput (editor opened on .vpd file) should be handled

In that specific case, there shouldn't even be session notification, as it's a file.
VPDEditor (or VirtualEditorInput) should track the session if was opened on, and only react to its closure

So this is 100% a PVMT bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants