Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port allocation are deleted when moving component ports from one component to another #2062

Open
LisaF268 opened this issue Jan 28, 2021 · 3 comments · May be fixed by #2796
Open

Port allocation are deleted when moving component ports from one component to another #2062

LisaF268 opened this issue Jan 28, 2021 · 3 comments · May be fixed by #2796

Comments

@LisaF268
Copy link

Context : a functional exchange is allocated to a component exchange, and related functions ports to components ports.

When the component port is moved from one component to another, the allocation link between the moved component port and the related function port is lost.
Allocation links between the other function/component ports and functional exchange/component exchanges are ok.
It is necessary to redo the allocation between the function port and the component port or between the functional exchange and component exchange to solve the problem

Before moving component port
After moving component port
ebausson-obeo added a commit to ebausson-obeo/capella that referenced this issue Jul 18, 2023
@ebausson-obeo
eclipse-capella#2062 Port delegations are kept when DnDing port to an…
01d87e8 
…y of target's ancerstors
ebausson-obeo added a commit to ebausson-obeo/capella that referenced this issue Aug 25, 2023
@ebausson-obeo
eclipse-capella#2062 Port delegations are kept when DnDing port to an…
d876113 
…y of target's ancerstors
pdulth pushed a commit to ebausson-obeo/capella that referenced this issue Sep 4, 2023
@ebausson-obeo @pdulth
eclipse-capella#2062 Port delegations are kept when DnDing port to an…
08a4af4 
…y of target's ancerstors
ebausson-obeo added a commit to ebausson-obeo/capella that referenced this issue Sep 6, 2023
@ebausson-obeo
eclipse-capella#2062 fix proposal.
28d46ee
ebausson-obeo added a commit to ebausson-obeo/capella that referenced this issue Sep 7, 2023
@ebausson-obeo
eclipse-capella#2062 Port delegations are kept when DnDing port to an…
ee5231e 
…y of target's

ancerstors

/ Please enter the commit message for your changes. Lines starting
/ with '/' will be kept; you may remove them yourself if you want to.
/ An empty message aborts the commit.
/
/ Date:      Mon Jul 10 16:28:01 2023 +0200
/
/ On branch conservation-port-delegation
/ Your branch is up to date with
'github-perso/conservation-port-delegation'.
/
/ You are currently cherry-picking commit 08a4af4.
/
/ Untracked files:
/	.project
/	common/plugins/org.polarsys.capella.common/.settings/org.eclipse.jdt.ui.prefs
/	core/plugins/.project
/	core/plugins/.settings/
/	core/plugins/org.polarsys.capella.core.sirius.analysis/.settings/org.eclipse.wst.validation.prefs
/	releng/cdo/features/.project
/	releng/cdo/features/.settings/
/	releng/cdo/plugins/.project
/	releng/cdo/plugins/.settings/
/	releng/plugins/.project
/	releng/plugins/.settings/
/	samples/.project
/	samples/.settings/
/	tests/plugins/.project
/	tests/plugins/.settings/
/
ebausson-obeo added a commit to ebausson-obeo/capella that referenced this issue Sep 7, 2023
@ebausson-obeo
eclipse-capella#2062 Port delegations are kept when DnDing port to an…
003b0a4 
…y of target's

ancerstors
ebausson-obeo added a commit to ebausson-obeo/capella that referenced this issue Sep 7, 2023
@ebausson-obeo
eclipse-capella#2062 fix part management in port-conservation functio…
feb3be6 
…nality.
ebausson-obeo added a commit to ebausson-obeo/capella that referenced this issue Oct 31, 2023
@ebausson-obeo
eclipse-capella#2062 Port delegations are kept when DnDing port to an…
79b5941 
…y of target's ancerstors
ebausson-obeo added a commit to ebausson-obeo/capella that referenced this issue Oct 31, 2023
@ebausson-obeo
eclipse-capella#2062 fix part management in port-conservation functio…
fcffa52 
…nality.
ebausson-obeo added a commit to ebausson-obeo/capella that referenced this issue Nov 14, 2023
@ebausson-obeo
eclipse-capella#2062 Port delegations are kept when DnDing port to an…
713dbaa 
…y of target's ancerstors
ebausson-obeo added a commit to ebausson-obeo/capella that referenced this issue Nov 14, 2023
@ebausson-obeo
eclipse-capella#2062 fix part management in port-conservation functio…
b471fe3 
…nality.
ebausson-obeo added a commit to ebausson-obeo/capella that referenced this issue Nov 14, 2023
@ebausson-obeo
eclipse-capella#2062 Adding test cases.
5375000
@SteveMonnier
Copy link
Contributor

Capella2062Port_allocation.zip
Steps to validate:

  • import the attached Capella project
  • open the existing LAB diagram
  • Drag and drop the black port on LC1 to LC11
    -> Validation: The green reference with dashes between the moved port and LogicalFunction1 is still displayed

ebausson-obeo added a commit to ebausson-obeo/capella that referenced this issue Nov 16, 2023
@ebausson-obeo
eclipse-capella#2062 Adding test cases.
2b67b8a
ebausson-obeo added a commit to ebausson-obeo/capella that referenced this issue Nov 16, 2023
@ebausson-obeo
eclipse-capella#2062 Adding test cases.
8616e9e
ebausson-obeo added a commit to ebausson-obeo/capella that referenced this issue Dec 20, 2023
@ebausson-obeo
eclipse-capella#2062 Adding a case that was untreated when DnDing por…
fe6cf8a 
…ts with existing allocations.
@SteveMonnier
Copy link
Contributor

Following the last update, there are 2 more scenarios to validate from the same sample and same diagram:
#2 Steps to validate:

  • Open the existing LAB diagram
  • Create a new Logicial function in LC1
  • Drag and drop the orange port on LogicalFunction2 to the newly created Logical function
    -> Validation: The dashed references are still displayed

#3 Steps to validate:

  • Open the existing LAB diagram
  • Create a new Logicial function in LA1
  • Drag and drop the green port on LogicalFunction1 to the newly created Logical function
    -> Validation: The dashed references are still displayed

SteveMonnier added a commit to SteveMonnier/capella that referenced this issue Jan 10, 2024
@SteveMonnier
eclipse-capella#2062 Handle dnd of ComponentExchange with allocated F…
ed6ff15 
…unctionExchange

Drag and dropping a port of a functional exchange that is allocated to a
ComponentExchange will not remove its allocation anymore.
@SteveMonnier
Copy link
Contributor

2062test_functional_exchange_allocation_on_move.zip
New scenario handle by the PR #2788 drag and droping a port will not clear the ComponentExchange from its allocated FunctionalExchanges. Using the new sample from archive [2062test_functional_exchange_allocation_on_move.zip the scenario is:

  • Open the existing LAB diagram
  • Drag an orange port from LogicalFunction2 and drop it on LogicalFunction3
  • Validation: All 4 dashed reference are still displayed. C1 still has both "Allocated Functional Exchange"
  • Drag the orange port from LogicalFunction2 and drop it on LogicalFunction4
  • Validation: All 4 dashed reference are still displayed. C1 still has both "Allocated Functional Exchange"
  • Drag the port CP1 (ComponentExchange end) from LC3 and drop it on LC2
  • Validation: Only 3 dashed reference are still displayed, the one from CP1 to FIP2 on LogicalFunction 4 has been removed. C1 still has both "Allocated Functional Exchange". CP1 only has FIP 1 in its allocated ports

SteveMonnier pushed a commit to SteveMonnier/capella that referenced this issue Jan 26, 2024
@ebausson-obeo @SteveMonnier
eclipse-capella#2062 Port delegations are kept when DnDing port to an…
1ef973a 
…y of target's ancerstors
SteveMonnier pushed a commit to SteveMonnier/capella that referenced this issue Jan 26, 2024
@ebausson-obeo @SteveMonnier
eclipse-capella#2062 fix part management in port-conservation functio…
f15eaac 
…nality.
SteveMonnier pushed a commit to SteveMonnier/capella that referenced this issue Jan 26, 2024
@ebausson-obeo @SteveMonnier
eclipse-capella#2062 Adding a case that was untreated when DnDing por…
d9c63b6 
…ts with existing allocations.
SteveMonnier added a commit to SteveMonnier/capella that referenced this issue Jan 26, 2024
@SteveMonnier
eclipse-capella#2062 Handle dnd of ComponentExchange with allocated F…
cb3ca93 
…unctionExchange

Drag and dropping a port of a functional exchange that is allocated to a
ComponentExchange will not remove its allocation anymore.
SteveMonnier pushed a commit to SteveMonnier/capella that referenced this issue Apr 9, 2024
@ebausson-obeo @SteveMonnier
eclipse-capella#2062 Port delegations are kept when DnDing port to an…
410ce27 
…y of target's ancerstors
SteveMonnier pushed a commit to SteveMonnier/capella that referenced this issue Apr 9, 2024
@ebausson-obeo @SteveMonnier
eclipse-capella#2062 fix part management in port-conservation functio…
45de484 
…nality.
SteveMonnier pushed a commit to SteveMonnier/capella that referenced this issue Apr 9, 2024
@ebausson-obeo @SteveMonnier
eclipse-capella#2062 Adding a case that was untreated when DnDing por…
57c1279 
…ts with existing allocations.
SteveMonnier added a commit to SteveMonnier/capella that referenced this issue Apr 9, 2024
@SteveMonnier
eclipse-capella#2062 Handle dnd of ComponentExchange with allocated F…
100a543 
…unctionExchange

Drag and dropping a port of a functional exchange that is allocated to a
ComponentExchange will not remove its allocation anymore.
@lredor lredor linked a pull request Jun 5, 2024 that will close this issue
Conservation port delegation master #2796
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Conservation port delegation master SteveMonnier/capella
2 participants
@SteveMonnier @LisaF268