Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail when cell outputs include current timestamp #32

Open
HelenCEBM opened this issue Feb 24, 2020 · 3 comments
Open

Tests fail when cell outputs include current timestamp #32

HelenCEBM opened this issue Feb 24, 2020 · 3 comments
Assignees

Comments

@HelenCEBM
Copy link
Contributor

@sebbacon
Copy link
Contributor

sebbacon commented Feb 24, 2020

Ideally we do want to test the output is as expected, but unfortunately the default output of the panel regression includes the current time stamp.

There are three possible approaches to this.

  1. Skip checking output
  • This is a last resort as we'd really like tests to do something
  1. Add a regular expression here to replace timestamps in panel regression summaries with a string like xx:xx
  • Doable, but because times and dates might (in other contexts) be relevant, we'd have to include panel-regression-specific identifiers in the the regex, and adding code for one odd exception isn't great in terms of long term framework maintenance (the current regexes linked above are globally and safely applicable)
  1. Change the output not to include time and date stamps
  • The current output is the default representation of a PanelEffectsResults which I presume is summary
  • The fix would be to specifically output the results we're interested in, rather than the kitchen sink (e.g. rsquared, pvalues etc)
    • However, if we are interested in basically everything except the date + time the regression was run, this will be a bit arduous

Thoughts?

@CarolineMorton
Copy link
Contributor

Option 3: We could probably get away with the Parameter Estimates, Log Likelihood, Entities I suspect. Could we add in some magic that allows us to pass in arguments to keep (in this case the above) so that it can be reused for other types of panels?

@madwort
Copy link
Contributor

madwort commented Jul 29, 2020

Option 4: use freezegun to ensure that the current time stamp is always some preset value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants