-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ingest repos in the opensafely org #187
Comments
I'd be inclined to add _TEAMS = {
"ebmdatalab": _TECH_TEAMS,
"opensafely-core": _TECH_TEAMS,
"opensafely": ["research"]
} then modify def _repo_owners(org):
teams = _TEAMS[org]
return {repo: team for team in teams for repo in query.team_repos(org, team)} leaving other references to |
Thanks, @Jongmassey. That's a sound alternative. Before choosing between modifying GitHub and modifying metrics, we should decide whether we want our GitHub orgs to have a similar team structure. We should also check whether ingesting opensafely repos affects our current dashboards. |
from memory, changing |
That sounds like a good technical solution. However, we've decided not to do this work at the moment as we think we have enough metrics data for the current Codespaces usage. If/when we have more people using Codespaces we should definitely look at implementing this. |
To help us understand how researchers are using Codespaces, it would be useful to derive the distribution of time deltas between when a study repo was created and when an associated Codespace was last used (opensafely-core/codespaces-initiative#68). This distribution would tell us how many researchers are using Codespaces to update code in older study repos; these researchers may need development environments with older versions of Python and R packages (e.g. from
python:v1
).Study repos are associated with the opensafely org, but at present, metrics ingests repos in the ebmdatalab and opensafely-core orgs. Consequently, metrics should also ingest repos in the opensafely org.
Making this change is more complicated than adding
"opensafely"
to_ORGS
:metrics/metrics/github/github.py
Line 10 in 5db873c
This is because metrics assumes that each org has three tech teams:
metrics/metrics/github/github.py
Line 9 in 5db873c
metrics/metrics/github/github.py
Lines 172 to 173 in 5db873c
The opensafely org doesn't have three tech teams, so this query fails. If it had these teams, then it should succeed, and
_repo_owners
should return a dict containing all study repos, because members of these teams would be owners of the opensafely org.The text was updated successfully, but these errors were encountered: