Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve new pipeline tests #112

Open
madwort opened this issue Jul 2, 2021 · 1 comment
Open

Improve new pipeline tests #112

madwort opened this issue Jul 2, 2021 · 1 comment

Comments

@madwort
Copy link
Contributor

madwort commented Jul 2, 2021

One test of the new pipeline was added in euctr/crawl/tests/test_get_trials_from_db.py - it would be nice to add this type of test for more of this code, to mimic what @NickCEBM was doing in his notebook.
We can generate initial test cases by simply wrapping the helper functions with e.g. input_dataframe.head().to_csv('/path/to/my/file'), but then we would ideally groom the data to exercise more of the code / edge cases / etc.

@madwort
Copy link
Contributor Author

madwort commented Jul 2, 2021

Nb. the new code loads directly from the database, so be careful with types when loading from CSV - things like bools & dates are converted to python primitives from db but string objects from csv.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant