Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary methods from Session interface #8

Open
aoberoi opened this issue May 9, 2014 · 0 comments
Open

Remove unnecessary methods from Session interface #8

aoberoi opened this issue May 9, 2014 · 0 comments

Comments

@aoberoi
Copy link
Collaborator

aoberoi commented May 9, 2014

The following methods are not methods that Session is meant to expose:

  • ValidateSession
  • GetPartnerIdFromSessionId

If these are being used in testing, its best to build them as testing utilities and to only test the public API of an object. This is testing best practices.
eauge pushed a commit that referenced this issue May 10, 2014
Session exposed Api reviewed
0cc6691 
Methods ValidateSession and  GetPartnerIdFromSessionId moved to tests.
Related to issue #8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aoberoi