Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove partnerId property from Session object #7

Open
aoberoi opened this issue May 9, 2014 · 0 comments
Open

Remove partnerId property from Session object #7

aoberoi opened this issue May 9, 2014 · 0 comments

Comments

@aoberoi
Copy link
Collaborator

aoberoi commented May 9, 2014

All public facing APIs refer to this value as API Key; partnerId or partnerKey are just aliases that some older parts of our internal services use.

In fact, there is no reason API Key needs to be exposed from Session at all. Its best to just remove it.
eauge referenced this issue May 10, 2014
ApiKey and ApiSecret are private in Session
3530694
eauge pushed a commit that referenced this issue May 10, 2014
Fixed bugs by testing Network Api
f7019b5 
In Session, ApiKey and ApiSecret are exposed to publics gets as in the
Java version. Issue #7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aoberoi