Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ApiKey and ApiSecret should not be settable on OpenTok #15

Open
aoberoi opened this issue May 9, 2014 · 0 comments
Open

ApiKey and ApiSecret should not be settable on OpenTok #15

aoberoi opened this issue May 9, 2014 · 0 comments

Comments

@aoberoi
Copy link
Collaborator

aoberoi commented May 9, 2014

Probably just use the getter, not the setter. Once the object is initialized, if those get modified, the HttpOpenTok object will not work properly since it still holds onto the old values. In general there is no use case for setting these values after object construction.
eauge pushed a commit that referenced this issue May 10, 2014
ApiKey and ApiSecret sets set to internal
2190663 
Related to issue #15
eauge pushed a commit that referenced this issue May 10, 2014
ApiKey and ApiSecret sets set to private
7d0ee7d 
They were set to internal in a previous commit, but it makes more sense
to use private because only code in the same class needs to use it.
Related to issue #15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aoberoi