Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenTok constructors should not have no param version #14

Open
aoberoi opened this issue May 9, 2014 · 0 comments
Open

OpenTok constructors should not have no param version #14

aoberoi opened this issue May 9, 2014 · 0 comments

Comments

@aoberoi
Copy link
Collaborator

aoberoi commented May 9, 2014

Reading from ConfigurationManagement in the constructor is a no-no. The app developer may use his own Dependency Injection system, so if they choose to specify these constants in ConfigurationManagement, they should pass those values in themselves.
eauge pushed a commit that referenced this issue May 10, 2014
Empty constructor has been removed
fb914da 
Related to issue #14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aoberoi