Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework advanced-search form query live-update. #44

Open
sevko opened this issue Jun 3, 2014 · 0 comments
Open

Rework advanced-search form query live-update. #44

sevko opened this issue Jun 3, 2014 · 0 comments
Assignees

Comments

@sevko
Copy link
Collaborator

sevko commented Jun 3, 2014

Currently, when the user is entering data into the advanced search-form, a loop assembles the full-query represented by the form and checks it for equality with the query already inside the search bar. This approach was taken because the Javascript callbacks for a change in an input[type=text] field's value occasionally failed, and failed to update the query bar, while polling at intervals invariably succeeded.

Another attempt to implement callbacks is necessary, because the looping mechanism in place is both wasteful (queries get regenerated sixty times a second), and bad form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant