Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seperate out unnessecary functions from library #3

Open
luigi311 opened this issue Jul 17, 2024 · 0 comments
Open

Seperate out unnessecary functions from library #3

luigi311 opened this issue Jul 17, 2024 · 0 comments

Comments

@luigi311
Copy link

Looks like you are doing a lot of things in your library which shouldn't really be done in the library section. For example you have functions that will collect all images in a folder and return the path, this has nothing to really do with the stacking functions. The stacking functions should just take in an array of images already good to go and the stacking functions just need to do the processing. Those preprocessing/helper functions are probably more suited for being in the example code only so users can see how to use the function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant