-
-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide journal recovery messages during test suite run #5469
Hide journal recovery messages during test suite run #5469
Conversation
exist-core/src/main/java/org/exist/storage/recovery/RecoveryManager.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the PR contains content of another PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great enhancement to have less output during tests!
@dizzzz @reinhapa I kept the journal improvements and CI improvements in a single PR, as that is what I had already done for 4.x.x, 5.x.x, and 6.x.x; albeit in those cases I needed to do both in a single PR to be able to see what was going on. I kept these things as separate commits at least. If you feel this PR here must be split into two - let me know and I will do so... |
69a6c23
to
49fdba7
Compare
It is OK for me, as it is intentional |
I m also curious what the JDK has to do with it. Since we use temurin not just on CI here, but also in Docker and all other repos in the org, I m not a fan of changing it without reason. If there is a reason to change, we should stay consistent elsewhere in the org. |
I'm ok changing the JDK for the sake of having the old versions, but on the |
It looks like that switching to the JVM Adam suggested all kind of strange test/fork/... issues occur. Looking at the discussions it is probably better to split the jvm change and the recovery log code delta. |
We then at least can rule out side effects from the JDK change... Just to be clear I'm full in the hiding suff! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@duncdrum (cc @reinhapa) As I wrote before you posted, see: "as that is what I had already done for 4.x.x, 5.x.x, and 6.x.x"
@duncdrum We are now using Liberica (and not Temurin) for eXist-db 4.x.x, 5.x.x, and 6.x.x. I am also a fan of consistency and so I wanted to use Liberica also for 7.x.x in THIS repo.
Yes, the features of eXist-db 4.x.x, 5.x.x, and 6.x.x only reliably run 100% on Java 8. Whilst you can run some parts of eXist-db 4.x.x, 5.x.x, and 6.x.x on newer Java, you will find various parts that throw exceptions due to changes in the JDK after Java 8; JAXB, Mail, Activation, Image, etc. There does not appear to be a Temurin build available for Java 8 in macOS (at least in CI) so we simply can't use Temurin in CI, however there is one for Liberica. That is the reason for the change. I see a reason to drop Temurin, but no reason not to use Liberica (which is also based on OpenJDK).
I am not so concerned about other repos in this org as they each have different requirements that I expect to be set by the owners of those repos. As the JDK change seems to be of concern, I will move it to a separate PR. However I think that we should choose one JDK vendor across 4.x.x, 5.x.x, 6.x.x, and 7.x.x and stick to it in this repo. As Temurin won't work for us (no JDK 8 support on macOS in CI) we need to choose one of the others. |
…o hide the Journal Recovery progress bars
…est suite so as not to pollute the output
49fdba7
to
bfa724e
Compare
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Stops the CI logs from getting polluted