Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update baseline_resync branch with latest commits #234

Draft
wants to merge 7 commits into
base: baseline_resync
Choose a base branch
from

Conversation

koujl
Copy link

@koujl koujl commented Nov 29, 2024

No description provided.

Hooper9973 and others added 7 commits November 5, 2024 02:13
this PR aims to support spare replicas in raft test framework , which is essential for testing pg move. what`s more, a basic replace_member UT is added
…hunk_id field to shard_info_superblk.

2. Enhance defensive checks in ChunkSelector for input validation and exception handling.

3. Adapt unit tests and introduce PGExceedSpaceTest.
1. Add check to ensure max_it points to an available chunk.
   If not, it indicates there are no available chunks left.
2. Add safeguards in the create and recover pg paths to ensure
   the pg size cannot be zero.
1 change on_destroy signature to adapt to homestore
2 add is leader check before any raft write operation
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 65.63981% with 145 lines in your changes missing coverage. Please review.

Please upload report for BASE (baseline_resync@dac10d8). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/lib/homestore_backend/hs_shard_manager.cpp 45.34% 42 Missing and 5 partials ⚠️
src/lib/homestore_backend/heap_chunk_selector.cpp 78.12% 23 Missing and 19 partials ⚠️
...ib/homestore_backend/replication_state_machine.cpp 28.57% 22 Missing and 3 partials ⚠️
src/lib/homestore_backend/hs_pg_manager.cpp 73.77% 11 Missing and 5 partials ⚠️
src/lib/homestore_backend/hs_blob_manager.cpp 30.00% 4 Missing and 3 partials ⚠️
...lib/homestore_backend/snapshot_receive_handler.cpp 77.77% 3 Missing and 1 partial ⚠️
src/lib/homestore_backend/index_kv.cpp 0.00% 2 Missing and 1 partial ⚠️
src/lib/homestore_backend/heap_chunk_selector.h 85.71% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                Coverage Diff                 @@
##             baseline_resync     #234   +/-   ##
==================================================
  Coverage                   ?   65.39%           
==================================================
  Files                      ?       33           
  Lines                      ?     2254           
  Branches                   ?      252           
==================================================
  Hits                       ?     1474           
  Misses                     ?      653           
  Partials                   ?      127           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiaoxichen
Copy link
Collaborator

I think you can rebase and force push @yuwmao

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants