Fix: Retain Current Page in UUID Table During Lazy Loading #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The loggings are an artifact from a different branch, not sure why it stayed; can remove if needed. |
TeachMeTW
force-pushed
the
fix/loading-placement
branch
from
80d3e3f to
dc80bc1
Compare
|
Removed unnecessary logging |
|
@JGreenlee Please Review |
JGreenlee
reviewed
Oct 18, 2024
Comment on lines
-292
to
+298
| page_current=0, # page number that user is on | ||
| page_current=page_current, # set to current page |
There was a problem hiding this comment.
Note to self: this is basically the fix. Instead of this always being 0, we keep track of page_current and pass it in here
JGreenlee
reviewed
Oct 18, 2024
Comment on lines
+25
to
+34
| dcc.Tabs( | ||
| id="tabs-datatable", | ||
| value='tab-uuids-datatable', | ||
| children=[ | ||
| dcc.Tab(label='UUIDs', value='tab-uuids-datatable'), | ||
| dcc.Tab(label='Trips', value='tab-trips-datatable'), | ||
| dcc.Tab(label='Demographics', value='tab-demographics-datatable'), | ||
| dcc.Tab(label='Trajectories', value='tab-trajectories-datatable'), | ||
| ] | ||
| ), |
There was a problem hiding this comment.
formatting-only change, but acceptable
JGreenlee
reviewed
Oct 18, 2024
Comment on lines
+120
to
+124
| def render_content( | ||
| tab, store_uuids, store_excluded_uuids, store_trips, store_demographics, store_trajectories, | ||
| start_date, end_date, timezone, n_intervals, key_list, current_page, | ||
| loaded_uuids_store, all_data_loaded | ||
| ): |
There was a problem hiding this comment.
I see; current_page added here so it can be used below
JGreenlee
reviewed
Oct 18, 2024
JGreenlee
reviewed
Oct 18, 2024
JGreenlee
reviewed
Oct 18, 2024
JGreenlee
reviewed
Oct 18, 2024
Co-authored-by: Jack Greenlee <[email protected]>
Co-authored-by: Jack Greenlee <[email protected]>
Co-authored-by: Jack Greenlee <[email protected]>
JGreenlee
reviewed
Oct 18, 2024
| html.Div(id='tabs-content'), | ||
| dcc.Store(id='selected-tab', data='tab-uuids-datatable'), # Store to hold selected tab | ||
| dcc.Interval(id='interval-load-more', interval=20000, n_intervals=0), # default loading at 10s, can be lowered or hightened based on perf (usual process local is 3s) | ||
| dcc.Interval(id='interval-load-more', interval=24000, n_intervals=0), # Interval for loading more data |
There was a problem hiding this comment.
Interval increased; ok for now until we implement a better solution that is not as fragile and does not depend on an arbitrary "magic number"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes issue #129, where the UUID table did not retain the user's current page during lazy loading updates. With this fix, the page now stays on the user's current page even as new data is loaded.
Problem
Previously, when lazy loading was in progress, navigating through the UUID table would reset the user back to the first page upon each data update. This disrupted the user experience, especially when trying to review data in real-time before the entire dataset was loaded.
Solution
Impact
Testing
8mb.video-VqM-0kSE84XU.mp4
Closes: Fixes #129