From 1ddc01bd8766f5ce4fd253b5dbd6d96f654eef58 Mon Sep 17 00:00:00 2001 From: Natalie Schultz <90212258+nataliejschultz@users.noreply.github.com> Date: Tue, 19 Sep 2023 02:35:48 -0600 Subject: [PATCH] Formatting change Adding spaces to see if that fixes the secret not being set. Also, trying to access the variables directly without using the get method. --- .github/workflows/nominatim-docker-test.yml | 6 +++--- emission/individual_tests/TestNominatim.py | 2 ++ 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/nominatim-docker-test.yml b/.github/workflows/nominatim-docker-test.yml index c0d204609..4f4ea3b6d 100644 --- a/.github/workflows/nominatim-docker-test.yml +++ b/.github/workflows/nominatim-docker-test.yml @@ -31,8 +31,8 @@ jobs: - name: Test nominatim env: - GEOFABRIK_QUERY_URL: "https://geocoding.geofabrik.de/${{secrets.GEOFABRIK_API}}" - TEST_KEY: ${{secrets.TEST_SECRET}} - TEST_ENVVAR: "https://geocoding.geofabrik.de/${{secrets.TEST_SECRET}}" + GEOFABRIK_QUERY_URL: "https://geocoding.geofabrik.de/${{ secrets.GEOFABRIK_API }}" + TEST_KEY: ${{ secrets.TEST_SECRET }} + TEST_ENVVAR: "https://geocoding.geofabrik.de/${{ secrets.TEST_SECRET }}" TEST_STR: "https://geocoding.geofabrik.de/" run: docker-compose -f emission/integrationTests/docker-compose.yml up --exit-code-from web-server diff --git a/emission/individual_tests/TestNominatim.py b/emission/individual_tests/TestNominatim.py index 03640c630..03d08b274 100644 --- a/emission/individual_tests/TestNominatim.py +++ b/emission/individual_tests/TestNominatim.py @@ -18,6 +18,8 @@ print("Starting to test Nominatim") #temporarily sets NOMINATIM_QUERY_URL to the environment variable for testing. +print("testkey", TEST_KEY) +print("testenvvar", TEST_ENVVAR) NOMINATIM_QUERY_URL_env = os.environ.get("NOMINATIM_QUERY_URL", "") NOMINATIM_QUERY_URL = NOMINATIM_QUERY_URL_env if NOMINATIM_QUERY_URL_env != "" else eco.NOMINATIM_QUERY_URL GEOFABRIK_QUERY_URL = os.environ.get("GEOFABRIK_QUERY_URL")