From 9f3ac2e10f82f7422989d44db75eb88c6de1bcd9 Mon Sep 17 00:00:00 2001 From: Shankari Date: Mon, 9 May 2022 12:25:33 -0700 Subject: [PATCH] Remove NOP if statement I added this as part of the https://github.com/e-mission/e-mission-phone/pull/825 PR to try and duplicate this special case handling of the enketo code https://github.com/e-mission/e-mission-phone/blob/59690cb503c682cf09b3681db70aeafa8d4631c0/www/js/diary/services.js#L1127 However, I actually ended up handling it at https://github.com/e-mission/e-mission-phone/pull/825/files#diff-4d928ea1f0def79e554ae472efcde3c3cfb464593833e77b9bc4dae5017bd244R1140 (in `readTripsAndUnprocessedInputs` instead) So this NOP `if` statement is no longer required --- www/js/diary/services.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/www/js/diary/services.js b/www/js/diary/services.js index 056f4a764..751b88600 100644 --- a/www/js/diary/services.js +++ b/www/js/diary/services.js @@ -2,7 +2,7 @@ angular.module('emission.main.diary.services', ['emission.plugin.logger', 'emission.services', 'emission.main.common.services', - 'emission.incident.posttrip.manual', 'emission.survey.multilabel.services', 'emission.survey.enketo.answer']) + 'emission.incident.posttrip.manual', 'emission.survey.enketo.answer']) .factory('DiaryHelper', function(CommonGraph, PostTripManualMarker, $translate){ var dh = {}; // dh.expandEarlierOrLater = function(id) { @@ -1111,8 +1111,6 @@ angular.module('emission.main.diary.services', ['emission.plugin.logger', console.log(mrString); timeline.data.unifiedConfirmsResults = {} manualResults.forEach(function(mr, index) { - if (ConfirmHelper.INPUTS[index].key == "manual/survey_response") { - } timeline.data.unifiedConfirmsResults[ConfirmHelper.INPUTS[index]] = mr; }); }