Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent/change content of email sent to user when they change their email address #121

Closed
jogwen opened this issue Feb 9, 2013 · 3 comments
Assignees
Milestone

Comments

@jogwen
Copy link

jogwen commented Feb 9, 2013

Currently an user changing their email address prompts the sending of another "click here to confirm your email address" email which is not right as the account is already activated. Either prevent this email notification, or change its content. Ideally it should be sent to the old email address asking them to confirm that they approve of it being changed to the new email address.

@ghost ghost assigned jogwen Feb 9, 2013
@mattions
Copy link
Contributor

mattions commented Feb 9, 2013

Confirm your e-mail address is not "Activate your account".
If a user change the e-mail address, than I guess he/she has to confirm it
again.

Does not make sense?

On Sat, Feb 9, 2013 at 5:05 PM, jogwen [email protected] wrote:

Currently an user changing their email address prompts the sending of
another "click here to confirm your email address" email which is not right
as the account is already activated. Either prevent this email
notification, or change its content. Ideally it should be sent to the old
email address asking them to confirm that they approve of it being changed
to the new email address.


Reply to this email directly or view it on GitHubhttps://github.com//issues/121..

Michele Mattioni, PhD
http://michelemattioni.me

@jogwen
Copy link
Author

jogwen commented Feb 9, 2013

I changed it a bit so that the user has to activate their user account by
clicking a link in the email. Only then can they log in. I did this so that
we could be sure that they can use password reset and receive email
notifications etc (otherwise they could put any old email address in).

For clarity, activating an email account is not the same as approving a
participant. Approving a participant allows the participant/events to be
shown on the website. Activating an email account allows user to log in.

I agree that it does make sense that they have to confirm it again if they
change email address, it's just that at the moment in my local branch I've
changed that email template so that it refers to activating their user
account, so I either have to roll that change back so that it works for
both initial account activation and changing email address on an existing
account, or provide an alternative email text for the latter ... although I
think it's a little broken at the moment anyway because it changes the
email address in the database before sending the confirmation email to the
new email address, which I don't think is right on several counts:

  • why send an email to confirm a change of email address to the new email
    address
    ?
  • why change the email address before sending the email to get confirmation?

I think it should be sent to the old email address asking them to confirm
that they approve of it being changed to the new email address, and once
they've confirmed then the email address in the database could be changed
to the new one.

On 9 February 2013 17:13, Michele Mattioni [email protected] wrote:

Confirm your e-mail address is not "Activate your account".
If a user change the e-mail address, than I guess he/she has to confirm it
again.

Does not make sense?

On Sat, Feb 9, 2013 at 5:05 PM, jogwen [email protected] wrote:

Currently an user changing their email address prompts the sending of
another "click here to confirm your email address" email which is not
right
as the account is already activated. Either prevent this email
notification, or change its content. Ideally it should be sent to the
old
email address asking them to confirm that they approve of it being
changed
to the new email address.


Reply to this email directly or view it on GitHub<
https://github.com/e-Luminate/eluminate_web/issues/121>..

Michele Mattioni, PhD
http://michelemattioni.me


Reply to this email directly or view it on GitHubhttps://github.com//issues/121#issuecomment-13334379..

@jogwen
Copy link
Author

jogwen commented Feb 12, 2013

Confusing email and screens fixed by 512c5ab. Opened new issue #167 for functionality bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants