-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
company logo size forced #113
Comments
Doesn't just setting "height: 50px; width: auto; max-width: 100px;" do enough? |
That's not the prefect answer, of course; would be better to have one of thos euser-can-resize, choose-which-bit-of-the-pic-you-want widgets such as are often used for portraits. That's def only for future study! :-) |
so, for the logo, we assign a logo class via CSS and we have that as normal style? on the visual Exhibition we display the logo in the carosel, but also in the page, don't we? |
Yes was just wondering about that... logo on detail prolly should be bigger than in carousel. Just been looking at django-stdimage (https://github.com/pivotal-energy-solutions/django-stdimage) Does this do what we want? |
If we used that, we could publish the size we want, and if people end up with a cropped image, they've only themselves to blame :-) |
Looks good to me, On Fri, Feb 8, 2013 at 5:14 PM, Kim SJ [email protected] wrote:
Michele Mattioni, PhD |
Good find Kim :D On 8 February 2013 17:19, Michele Mattioni [email protected] wrote:
|
Closing this because I think the css mostly keeps us out of trouble. I've opened a new issue #169 to cover longer-term issues. |
Right now any size for the logo can be uploaded, and this is not a good idea, cause they go all over the place.
We could enforce the size with HTML, however it means every-time we show the logo we have to remember the exact width and height (lots of duplication)
Or, we can have a standard format that we tell the user, and use only that.
I'm more happy for the second one.
The text was updated successfully, but these errors were encountered: