Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

company logo size forced #113

Closed
mattions opened this issue Feb 8, 2013 · 8 comments
Closed

company logo size forced #113

mattions opened this issue Feb 8, 2013 · 8 comments
Labels
Milestone

Comments

@mattions
Copy link
Contributor

mattions commented Feb 8, 2013

Right now any size for the logo can be uploaded, and this is not a good idea, cause they go all over the place.

We could enforce the size with HTML, however it means every-time we show the logo we have to remember the exact width and height (lots of duplication)

Or, we can have a standard format that we tell the user, and use only that.

I'm more happy for the second one.

@KimSJ
Copy link
Contributor

KimSJ commented Feb 8, 2013

Doesn't just setting "height: 50px; width: auto; max-width: 100px;" do enough?

@KimSJ
Copy link
Contributor

KimSJ commented Feb 8, 2013

That's not the prefect answer, of course; would be better to have one of thos euser-can-resize, choose-which-bit-of-the-pic-you-want widgets such as are often used for portraits. That's def only for future study! :-)

@mattions
Copy link
Contributor Author

mattions commented Feb 8, 2013

so, for the logo, we assign a logo class via CSS and we have that as normal style? on the visual Exhibition we display the logo in the carosel, but also in the page, don't we?

@KimSJ
Copy link
Contributor

KimSJ commented Feb 8, 2013

Yes was just wondering about that... logo on detail prolly should be bigger than in carousel. Just been looking at django-stdimage (https://github.com/pivotal-energy-solutions/django-stdimage) Does this do what we want?

@KimSJ
Copy link
Contributor

KimSJ commented Feb 8, 2013

If we used that, we could publish the size we want, and if people end up with a cropped image, they've only themselves to blame :-)

@mattions
Copy link
Contributor Author

mattions commented Feb 8, 2013

Looks good to me,
you could give it a spin.

On Fri, Feb 8, 2013 at 5:14 PM, Kim SJ [email protected] wrote:

If we used that, we dould publish the size we want, and if people end up
with a cropped image, they've only themselves to blame :-)


Reply to this email directly or view it on GitHubhttps://github.com//issues/113#issuecomment-13300611.

Michele Mattioni, PhD
http://michelemattioni.me

@jogwen
Copy link

jogwen commented Feb 8, 2013

Good find Kim :D

On 8 February 2013 17:19, Michele Mattioni [email protected] wrote:

Looks good to me,
you could give it a spin.

On Fri, Feb 8, 2013 at 5:14 PM, Kim SJ [email protected] wrote:

If we used that, we dould publish the size we want, and if people end up
with a cropped image, they've only themselves to blame :-)


Reply to this email directly or view it on GitHub<
https://github.com/e-Luminate/eluminate_web/issues/113#issuecomment-13300611>.

Michele Mattioni, PhD
http://michelemattioni.me


Reply to this email directly or view it on GitHubhttps://github.com//issues/113#issuecomment-13300866..

@KimSJ
Copy link
Contributor

KimSJ commented Feb 12, 2013

Closing this because I think the css mostly keeps us out of trouble. I've opened a new issue #169 to cover longer-term issues.

@KimSJ KimSJ closed this as completed Feb 12, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants