You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Expected behavior
I expect the data stored in the byte[]s to be mergeable, even if the library does not include a merge function
Additional context
I've tried writing different merge functions where I decode it signed, unsigned, swap the byte order, and have been unable to find a version that would work with the 32-bit output.
Possible fix
I am reasonably sure that this is because of this section:
if (hash < work[i]) {
work[i] = hash;
}
and that it would work if it used an unsigned lessthan, rather than the signed one, or if it masked before comparing
Even more context
I ran across this when testing semilattice + distributive laws in https://github.com/andimiller/schrodinger SuperMinHash merges fine with this merge method on all bit sizes, it does not work on SimHash or FastSimHash
The text was updated successfully, but these errors were encountered:
Describe the bug
The output of
MinHash.compute
cannot be merged with another output on hash sizes of under 64To Reproduce
Expected behavior
I expect the data stored in the
byte[]
s to be mergeable, even if the library does not include a merge functionAdditional context
I've tried writing different merge functions where I decode it signed, unsigned, swap the byte order, and have been unable to find a version that would work with the 32-bit output.
Possible fix
I am reasonably sure that this is because of this section:
and that it would work if it used an unsigned lessthan, rather than the signed one, or if it masked before comparing
Even more context
I ran across this when testing semilattice + distributive laws in https://github.com/andimiller/schrodinger
SuperMinHash
merges fine with thismerge
method on all bit sizes, it does not work onSimHash
orFastSimHash
The text was updated successfully, but these errors were encountered: