Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace deprecated Wrap and Wrapf #1278

Merged

Conversation

harry-hov
Copy link
Contributor

@harry-hov harry-hov commented Oct 1, 2024

Description

Wrap and Wrapf functionality has been moved to it's own module: "cosmossdk.io/errors".

Modified instances of Wrap and Wrapf to use "cosmossdk.io/errors" instead.

See: https://github.com/cosmos/cosmos-sdk/blob/v0.47.13/types/errors/errors.go#L7-L27


Closes #XXX

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments
  • Updated the scripts for local run, e.g genesis_config_commands.sh if the PR changes parameters
  • Add an issue in the e2e-tests repo if necessary

SDK Checklist

  • Import/Export Genesis
  • Registered Invariants
  • Registered Events
  • Updated openapi.yaml
  • No usage of go map
  • No usage of time.Now()
  • Used fixed point arithmetic and not float arithmetic
  • Avoid panicking in Begin/End block as much as possible
  • No unexpected math Overflow
  • Used sendCoin and not SendCoins
  • Out-of-block compute is bounded
  • No serialized ID at the end of store keys
  • UInt to byte conversion should use BigEndian

Full security checklist here


For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

`Wrap` and `Wrapf` functionality has been moved to it's own module: "cosmossdk.io/errors".

Modified instances of `Wrap` and `Wrapf` to use "cosmossdk.io/errors" instead.
@harry-hov harry-hov requested a review from a team as a code owner October 1, 2024 14:12
Copy link
Contributor

@keruch keruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for contributing!

x/lockup/keeper/store.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 54.05405% with 17 lines in your changes missing coverage. Please review.

Project coverage is 23.91%. Comparing base (031ecad) to head (9cf3817).
Report is 40 commits behind head on main.

Files with missing lines Patch % Lines
x/lockup/keeper/msg_server.go 27.27% 8 Missing ⚠️
x/lockup/types/msgs.go 57.14% 3 Missing ⚠️
x/dymns/client/cli/tx_update_resolve_address.go 0.00% 2 Missing ⚠️
x/lockup/keeper/grpc_query.go 83.33% 2 Missing ⚠️
x/sequencer/keeper/rotation.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1278      +/-   ##
==========================================
- Coverage   25.30%   23.91%   -1.40%     
==========================================
  Files         499      551      +52     
  Lines       98751   115442   +16691     
==========================================
+ Hits        24989    27607    +2618     
- Misses      70523    84153   +13630     
- Partials     3239     3682     +443     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtsitrin mtsitrin merged commit 41267b2 into dymensionxyz:main Oct 2, 2024
109 of 137 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants