Use SpendableCoins Interface instead of GetBalance

[Hellobloc]

dymension/x/iro/keeper/claim.go

Lines 37 to 46 in f3252be

	availableTokens := k.BK.GetBalance(ctx, claimer, plan.TotalAllocation.Denom)
	if availableTokens.IsZero() {
	return types.ErrNoTokensToClaim
	}
	// Burn all the FUT tokens the user have
	err := k.BK.SendCoinsFromAccountToModule(ctx, claimer, types.ModuleName, sdk.NewCoins(availableTokens))
	if err != nil {
	return err
	}

In the Claim method the user can burn FU tokens, this is done based on SendCoinsFromAccountToModule, which can be risky, specifically because the program supports the vestingAccount feature in GenesisAccount, which means that the balance returned by the GetBalance method may not always be spendable.

The vesting accounts may also contain Locked Coins, making it impossible to execute the claim method normally.

To avoid the potential risks that may exist, it is may more appropriate to use SpendableCoins.

[mtsitrin]

Hi @Hellobloc
can u elabroate on the potential risk u see?

The IRO/ tokens minted by the x/iro module only
The tokens distributes in the GenesisAccount are already of the settled denom (IBC/12345678ABCD)

not sure there's a scenario where the IRO/ tokens are locked for vesting
and even if they do, the claim will fail as expected

[Hellobloc]

Thank you very much for your reply.

Sorry for the lack info in this issue, I initially thought that the claim of RA token would not allowed be affected by vesting account. This means that even in a vesting account, the FU Tokens could still be burned to complete the RA Token claim. However, it seems that vesting accounts might prevent the RA Token claim, even these vesting account just want to burn the token which is not been lock in vesting. This means that a vesting account can not perform FU token burn operation unless he doesn't have any lock tokens

On the other hand, I thought that replacing the GetBalance operation with SpendableCoins would allow vesting accounts to execute the claim operation nomally. which means such a replacement would have a positive externality. So that's why i post this issue!

[mtsitrin]

Hi @Hellobloc
The vesting accounts defined on GenesisAccounts is on the Rollapp state
The IRO tokens claims are on the Hub

not sure how it's relates
also, the IRO/ token is not vesting anywhere

If u can share reproduction steps it will be very helpful