From c0774fc2699290f1e8500b806c9839d14f5ef7e2 Mon Sep 17 00:00:00 2001 From: Michael Tsitrin <114929630+mtsitrin@users.noreply.github.com> Date: Sun, 17 Nov 2024 16:12:11 +0200 Subject: [PATCH] fix(rollapp): fix store issue with hooks (#1489) --- x/rollapp/keeper/hard_fork.go | 4 ++-- x/rollapp/keeper/msg_server_update_state.go | 1 + x/rollapp/types/events.go | 9 ++++----- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/x/rollapp/keeper/hard_fork.go b/x/rollapp/keeper/hard_fork.go index 29f2915e8..5bf05fb29 100644 --- a/x/rollapp/keeper/hard_fork.go +++ b/x/rollapp/keeper/hard_fork.go @@ -43,9 +43,9 @@ func (k Keeper) HardFork(ctx sdk.Context, rollappID string, newRevisionHeight ui ctx.EventManager().EmitEvent( sdk.NewEvent( - types.EventTypeFraud, + types.EventTypeHardFork, sdk.NewAttribute(types.AttributeKeyRollappId, rollappID), - sdk.NewAttribute(types.AttributeKeyFraudHeight, fmt.Sprint(newRevisionHeight)), + sdk.NewAttribute(types.AttributeKeyNewRevisionHeight, fmt.Sprint(newRevisionHeight)), ), ) diff --git a/x/rollapp/keeper/msg_server_update_state.go b/x/rollapp/keeper/msg_server_update_state.go index 198355997..d199e9e38 100644 --- a/x/rollapp/keeper/msg_server_update_state.go +++ b/x/rollapp/keeper/msg_server_update_state.go @@ -150,6 +150,7 @@ func (k msgServer) UpdateState(goCtx context.Context, msg *types.MsgUpdateState) // TODO: enforce `final_state_update_timeout` if sequencer rotation is in progress // https://github.com/dymensionxyz/dymension/issues/1085 + rollapp = k.MustGetRollapp(ctx, msg.RollappId) k.IndicateLiveness(ctx, &rollapp) k.SetRollapp(ctx, rollapp) diff --git a/x/rollapp/types/events.go b/x/rollapp/types/events.go index e67366db2..1e56637c7 100644 --- a/x/rollapp/types/events.go +++ b/x/rollapp/types/events.go @@ -12,11 +12,10 @@ const ( AttributeKeyDAPath = "da_path" AttributeKeyStatus = "status" - // EventTypeFraud is emitted when a fraud evidence is submitted - EventTypeFraud = "fraud_proposal" - AttributeKeyFraudHeight = "fraud_height" - AttributeKeyFraudSequencer = "fraud_sequencer" - AttributeKeyClientID = "client_id" + // EventTypeHardFork is emitted when a fraud evidence is submitted + EventTypeHardFork = "hard_fork" + AttributeKeyNewRevisionHeight = "new_revision_height" + AttributeKeyClientID = "client_id" // EventTypeTransfersEnabled is when the bridge is enabled EventTypeTransfersEnabled = "transfers_enabled"