Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review Exceptions and Exception types #630

Open
andreaTP opened this issue Oct 31, 2024 · 0 comments
Open

Review Exceptions and Exception types #630

andreaTP opened this issue Oct 31, 2024 · 0 comments

Comments

@andreaTP
Copy link
Collaborator

Noticed those lines:

chicory/test-gen-plugin/src/main/java/com/dylibso/chicory/maven/JavaTestGen.java

Lines 306 to 308 in 6cba00b

case ASSERT_TRAP:
case ASSERT_EXHAUSTION:
return "ChicoryException";

probably catching a generic ChicoryException is too broad and we should review which Exception should be thrown.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andreaTP