Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory: improve error handling for "out of bounds memory access" #603

Open
evacchi opened this issue Oct 24, 2024 · 1 comment
Open

Memory: improve error handling for "out of bounds memory access" #603

evacchi opened this issue Oct 24, 2024 · 1 comment

Comments

@evacchi
Copy link
Collaborator

evacchi commented Oct 24, 2024

  • Current exception message does not carry any information about where the error occurred
  • Moreover, the exception is often raised by catching an IndexOutOfBoundsException, even when we are already aware of the limits; we should be able to check those limits explicitly, avoiding an expensive exception to be created
@electrum
Copy link
Collaborator

While I generally agree about not creating exceptions needlessly, does it actually matter here? When OOB access occurs, the WASM program is terminated.

I just noticed that Memory has a mix of UninstantiableException and WasmRuntimeException, which should be cleaned up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants